Skip to contentSkip to conversation

of_mtd: Fix header file include guard

PATCH Applied Rosenberger, Philipp 2 participants 4 messages Nov 28, 2013 – Dec 2, 2013 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 of_mtd: Fix header file include guard

It seems the include guard was copied from of_net.h.

---
 include/linux/of_mtd.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_mtd.h +1 -1
index 6f10e93..cb32d9c 100644
@@ -7,7 +7,7 @@
  */
 
 #ifndef __LINUX_OF_MTD_H
-#define __LINUX_OF_NET_H
+#define __LINUX_OF_MTD_H
 
 #ifdef CONFIG_OF_MTD
 

-- 1.7.9.5

XS Embedded GmbH
Peterzeller Strasse 8
D-78048 Villingen - Schwenningen

Telefon +49 (7721) 4060 - 428
Fax +49 (7721) 4060 - 499

www.xse.de
[email protected]

:::::::::: based.on.visions ::::::::::

XS Embedded GmbH
Geschäftsführung: Michael Maier, Rainer Oder

Handelsregister: Amtsgericht Freiburg i.Br., HRB 705237
Sitz der Gesellschaft: Peterzeller Strasse 8, 78048 Villingen-Schwenningen USt-Id Nummer: DE268786819

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.

#2 lore raw
In reply to a message not in the archive

+ device tree guys

Hi Grant/Rob,

It looks like this header is technically owned by you guys. Once we have a proper submission, should I merge this sort of change through MTD, or do one of you want to take care of it?

Hi Philpp,

Thanks for the patch! There are a few things to fix up though.

Quoted 1 line · Philipp

It seems the include guard was copied from of_net.h.

Good catch.

Note that all patches require a "Signed-off-by" line in the patch description, to signify (among other things) that this is your work and that you are submitting it under the GPLv2 license. See Documentation/SubmittingPatches (esp. point 12).

Quoted 32 lines
---
 include/linux/of_mtd.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_mtd.h +1 -2
index 6f10e93..cb32d9c 100644
@@ -7,7 +7,7 @@
  */
 
 #ifndef __LINUX_OF_MTD_H
-#define __LINUX_OF_NET_H
+#define __LINUX_OF_MTD_H
 
 #ifdef CONFIG_OF_MTD
 
-- 1.7.9.5

XS Embedded GmbH
Peterzeller Strasse 8
D-78048 Villingen - Schwenningen

Telefon +49 (7721) 4060 - 428
Fax +49 (7721) 4060 - 499

www.xse.de
[email protected]

:::::::::: based.on.visions ::::::::::

Quoted 8 lines

XS Embedded GmbH
Geschäftsführung: Michael Maier, Rainer Oder

Handelsregister: Amtsgericht Freiburg i.Br., HRB 705237
Sitz der Gesellschaft: Peterzeller Strasse 8, 78048 Villingen-Schwenningen USt-Id Nummer: DE268786819

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.

This confidentiality notice is incongruous with sending patches to a
public mailing list, for inclusion in an open source project. This
message (combined with a lack of a Signed-off-by) means we cannot take
your patch. Please remove this footer and resubmit, with a CC to [email protected] and devicetree-u79uwXL29TaiAVqoAR/[email protected]

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

Hi Brian,

Thanks for your replay and all the hints about submitting the correct way. Is it ok to paste the full git format-patch output like this?

Quoted 1 line

From a2e84efe0d5335547ca3e6c0a8bf8a026b0f2353 Mon Sep 17 00:00:00 2001

From: Philipp Rosenberger <[email protected]>
Date: Thu, 28 Nov 2013 12:36:52 +0100
Subject: [PATCH] of_mtd: Fix header file include guard

It seems the include guard was copied from of_net.h.

---
 include/linux/of_mtd.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_mtd.h +1 -1
index 6f10e93..cb32d9c 100644
@@ -7,7 +7,7 @@
  */
 
 #ifndef __LINUX_OF_MTD_H
-#define __LINUX_OF_NET_H
+#define __LINUX_OF_MTD_H
 
 #ifdef CONFIG_OF_MTD
 

--
1.7.9.5

Quoted 69 lines · Brian Norris

+ device tree guys

Hi Grant/Rob,

It looks like this header is technically owned by you guys. Once we have a proper submission, should I merge this sort of change through MTD, or do one of you want to take care of it?

Hi Philpp,

Thanks for the patch! There are a few things to fix up though.

Quoted 1 line · Philipp

It seems the include guard was copied from of_net.h.

Good catch.

Note that all patches require a "Signed-off-by" line in the patch description, to signify (among other things) that this is your work and that you are submitting it under the GPLv2 license. See Documentation/SubmittingPatches (esp. point 12).

Quoted 32 lines
---
 include/linux/of_mtd.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_mtd.h +1 -2
index 6f10e93..cb32d9c 100644
@@ -7,7 +7,7 @@
  */
 
 #ifndef __LINUX_OF_MTD_H
-#define __LINUX_OF_NET_H
+#define __LINUX_OF_MTD_H
 
 #ifdef CONFIG_OF_MTD
 
-- 1.7.9.5

XS Embedded GmbH
Peterzeller Strasse 8
D-78048 Villingen - Schwenningen

Telefon +49 (7721) 4060 - 428
Fax +49 (7721) 4060 - 499

www.xse.de
[email protected]

:::::::::: based.on.visions ::::::::::

Quoted 8 lines

XS Embedded GmbH
Geschäftsführung: Michael Maier, Rainer Oder

Handelsregister: Amtsgericht Freiburg i.Br., HRB 705237
Sitz der Gesellschaft: Peterzeller Strasse 8, 78048 Villingen-Schwenningen USt-Id Nummer: DE268786819

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.

This confidentiality notice is incongruous with sending patches to a public mailing list, for inclusion in an open source project. This message (combined with a lack of a Signed-off-by) means we cannot take your patch. Please remove this footer and resubmit, with a CC to [email protected] and [email protected].

Quoted 4 lines

Thanks,
Brian

Thank you for this hint. I forgot that the mailserver append this footer. I hope now there is no company footer anymore.

Best regards

Philipp

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Applied
#5 lore raw
In reply to a message not in the archive

Hi Philipp,

Quoted 29 lines · Philipp

Thanks for your replay and all the hints about submitting the correct way. Is it ok to paste the full git format-patch output like this?

From a2e84efe0d5335547ca3e6c0a8bf8a026b0f2353 Mon Sep 17 00:00:00 2001
From: Philipp Rosenberger <[email protected]>
Date: Thu, 28 Nov 2013 12:36:52 +0100
Subject: [PATCH] of_mtd: Fix header file include guard

It seems the include guard was copied from of_net.h.

---
 include/linux/of_mtd.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_mtd.h +1 -2
index 6f10e93..cb32d9c 100644
@@ -7,7 +7,7 @@
  */
 
 #ifndef __LINUX_OF_MTD_H
-#define __LINUX_OF_NET_H
+#define __LINUX_OF_MTD_H
 
 #ifdef CONFIG_OF_MTD
 
--
Quoted 1 line

1.7.9.5

That's workable for me, but that's not quite the standard way. The git-format-patch output is meant to be mailed directly (via git-send-email, for instance), not pasted into another email. If you paste it, then git-am will see two sets of email headers and may not understand it.

Quoted 8 lines · Brian Norris
Quoted 7 lines

+ device tree guys

Hi Grant/Rob,

It looks like this header is technically owned by you guys. Once we have a proper submission, should I merge this sort of change through MTD, or do one of you want to take care of it?

Unless someone complains soon, I'll take this via MTD. No one else should be creating conflicts on this file anyway.

...

Quoted 8 lines
Quoted 8 lines
Quoted 1 line

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.

This confidentiality notice is incongruous with sending patches to a
public mailing list, for inclusion in an open source project. This
message (combined with a lack of a Signed-off-by) means we cannot take
your patch. Please remove this footer and resubmit, with a CC to [email protected] and devicetree-u79uwXL29TaiAVqoAR/[email protected]

Quoted 7 lines
Quoted 4 lines

Thanks,
Brian

Thank you for this hint. I forgot that the mailserver append this footer. I hope now there is no company footer anymore.

Looks good now. Thanks.

Pushed to l2-mtd.git.

Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html