Skip to contentSkip to conversation

HID: hid-multitouch: add support for SiS panel in LG 23ET83V

PATCH In review Emanuel Krenz 2 participants 2 messages Dec 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: hid-multitouch: add support for SiS panel in LG 23ET83V

--------------------
From: Emanuel Krenz <[email protected]>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

---

I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't yet included in the hid-multitouch driver.
So I wrote following patch to include the ID number 1030 and patched the latest stable 3.12.5 kernel. The SiS touchpanel in my monitor works for me now. This is my first submitted patch by now, hope it's okay.

------------------

drivers/hid/hid-core.c +0 -0
@@ -1823,6 +1823,7 @@ static const struct hid_device_id hid_ha
     { HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, 

USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
USB_DEVICE_ID_SIS9200_TOUCH) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
USB_DEVICE_ID_SIS817_TOUCH) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SKYCABLE,
USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY,
USB_DEVICE_ID_SONY_BUZZ_CONTROLLER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY,
USB_DEVICE_ID_SONY_WIRELESS_BUZZ_CONTROLLER) },

drivers/hid/hid-ids.h +1 -0
@@ -755,6 +755,7 @@
 #define USB_VENDOR_ID_SIS2_TOUCH    0x0457
 #define USB_DEVICE_ID_SIS9200_TOUCH    0x9200
 #define USB_DEVICE_ID_SIS817_TOUCH    0x0817
+#define USB_DEVICE_ID_SIS1030_TOUCH    0x1030
 
 #define USB_VENDOR_ID_SKYCABLE            0x1223
 #define    USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER    0x3F07
drivers/hid/hid-multitouch.c +3 -0
@@ -1306,6 +1306,9 @@ static const struct hid_device_id mt_dev
     { .driver_data = MT_CLS_DEFAULT,
         HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
         USB_DEVICE_ID_SIS817_TOUCH) },
+    { .driver_data = MT_CLS_DEFAULT,
+        HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
+        USB_DEVICE_ID_SIS1030_TOUCH) },
 
     /* Stantum panels */
     { .driver_data = MT_CLS_CONFIDENCE,
drivers/hid/usbhid/hid-quirks.c +0 -0
@@ -86,6 +86,7 @@ static const struct hid_blacklist {
     { USB_VENDOR_ID_SIGMATEL, USB_DEVICE_ID_SIGMATEL_STMP3780, 

HID_QUIRK_NOGET },

     { USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH, 
HID_QUIRK_NOGET },
     { USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH, 

HID_QUIRK_NOGET },
+ { USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE,
HID_QUIRK_NOGET },
{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_1,
HID_QUIRK_NOGET },
{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_2,
HID_QUIRK_NOGET },

#1 lore raw
Quoted 9 lines · Emanuel Krenz

From: Emanuel Krenz <[email protected]>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't yet included in the hid-multitouch driver. So I wrote following patch to include the ID number 1030 and patched the latest stable 3.12.5 kernel. The SiS touchpanel in my monitor works for me now. This is my first submitted patch by now, hope it's okay.

Hi Emanuel

This time it doesn't have any Signed-off-by: line, but you should actually include your own :)

Also, your mail clinet unfortunately corrupted (line-wrapped) the patch, so that it can't be applied. Please fix your mail client so that it doesn't corrupt patches -- there are some hints in Documentation/email-clients.txt

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs