Skip to contentSkip to conversation

dont skip action order

PATCH In review Jamal Hadi Salim 2 participants 3 messages Dec 22, 2013 – Jan 1, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dont skip action order

attached.

cheers,
jamal

commit 58d78f9f6447df324cdeb99262442c5e3f1f924b

Author: Jamal Hadi Salim <[email protected]>
Date:   Sun Dec 22 10:34:18 2013 -0500

dont skip displaying of action chains or lists by TCA_ACT_MAX_PRIO

tc/m_action.c +1 -3
index 51085ec..77479d6 100644
@@ -32,7 +32,6 @@ static struct action_util * action_list;
 #ifdef CONFIG_GACT
 int gact_ld = 0 ; //fuckin backward compatibility
 #endif
-int batch_c = 0;
 int tab_flush = 0;
 
 static void act_usage(void)
@@ -304,7 +303,7 @@ tc_print_action(FILE * f, const struct rtattr *arg)
 
 	for (i = 0; i < TCA_ACT_MAX_PRIO; i++) {
 		if (tb[i]) {
-			fprintf(f, "\n\taction order %d: ", i + batch_c);
+			fprintf(f, "\n\taction order %d: ", i);
 			if (0 > tc_print_one_action(f, tb[i])) {
 				fprintf(f, "Error printing action\n");
 			}
@@ -312,7 +311,6 @@ tc_print_action(FILE * f, const struct rtattr *arg)
 
 	}
 
-	batch_c+=TCA_ACT_MAX_PRIO ;
 	return 0;
 }
 
#2 lore raw
Quoted 1 line · Stephen Hemminger

I applied all 8 patches

Thanks Stephen. I have one more - although it is not dependent on the kernel patch for flush counter, that patch makes it better. I will wait for Dave to take in the patch, test then send it to you.

cheers,
jamal