Skip to contentSkip to conversation

batman-adv: use batadv_compare_eth for concise

PATCH Superseded Ding Tianhong 2 participants 2 messages Dec 24, 2013

Subsystems (3)
Networking Network drivers Batman advanced

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Ding Tianhong

author
#0 lore raw

PATCH v2 7/20 batman-adv: use batadv_compare_eth for concise

It is better to use batadv_compate_eth instead of memcpy for concise style.

Cc Marek Lindner <[email protected]>
Cc Simon Wunderlich <[email protected]>
Cc Antonio Quartulli <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Tan Xiaojun <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
---
 net/batman-adv/originator.c        | 2 +-
 net/batman-adv/translation-table.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
net/batman-adv/originator.c +1 -1
index 8ab1434..803ab4b 100644
@@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2)
 	const void *data1 = container_of(node, struct batadv_orig_node,
 					 hash_entry);
 
-	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+	return batadv_compare_eth(data1, data2);
 }
 
 /**
net/batman-adv/translation-table.c +1 -1
index 4add57d..06506e6 100644
@@ -51,7 +51,7 @@ static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
 	const void *data1 = container_of(node, struct batadv_tt_common_entry,
 					 hash_entry);
 
-	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+	return batadv_compare_eth(data1, data2);
 }
 
 /**
Signature · 1 line
1.8.0
Acked-by on v2 7/20
#1 lore raw
Quoted 12 lines · Ding Tianhong

It is better to use batadv_compate_eth instead of memcpy for concise style.

Cc Marek Lindner <[email protected]>
Cc Simon Wunderlich <[email protected]>
Cc Antonio Quartulli <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Tan Xiaojun <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
Acked-by Antonio Quartulli <[email protected]>
Signature · 1 line
Antonio Quartulli