mac8011: slight optimization of addr compare

PATCH Superseded Ding Tianhong 1 participant 1 message Dec 24, 2013

Subsystems (3)

Networking Network drivers mac80211

lore

Share & tools

lore

Ding Tianhong

author

2013-12-24 11:28 UTC #0 lore raw

PATCH v2 11/20 mac8011: slight optimization of addr compare

Use the possibly more efficient ether_addr_equal to instead of memcmp.

Cc Johannes Berg <[email protected]>

Cc John W. Linville <[email protected]>

Cc David Miller <[email protected]>

Cc [email protected]

Signed-off-by Wang Weidong <[email protected]>

Signed-off-by Ding Tianhong <[email protected]>

---
 net/mac80211/iface.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

net/mac80211/iface.c +3 -4

index 7aa9f9d..a4f9812 100644
@@ -1497,8 +1497,8 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local,
 			bool used = false;
 
 			list_for_each_entry(sdata, &local->interfaces, list) {
-				if (memcmp(local->hw.wiphy->addresses[i].addr,
-					   sdata->vif.addr, ETH_ALEN) == 0) {
+				if (ether_addr_equal(local->hw.wiphy->addresses[i].addr,
+						     sdata->vif.addr)) {
 					used = true;
 					break;
 				}

@@ -1558,8 +1558,7 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local,
 			val += inc;
 
 			list_for_each_entry(sdata, &local->interfaces, list) {
-				if (memcmp(tmp_addr, sdata->vif.addr,
-							ETH_ALEN) == 0) {
+				if (ether_addr_equal(tmp_addr, sdata->vif.addr)) {
 					used = true;
 					break;
 				}

Signature · 1 line

1.8.0