ocfs2: Check existence of old dentry in ocfs2_link()
PATCH 1/1 ocfs2: Check existence of old dentry in ocfs2_link()
System call linkat first calls user_path_at(), check the existence
of old dentry, and then calls vfs_link()->ocfs2_link() to do the actual work. There may exist a race when Node A create a hard link for file while node B rm it.
Node A Node Buser_path_at()
->ocfs2_lookup(),
find old dentry exist
rm file, add inode say inodeA to orphan_dir
call ocfs2_link(),create a
hard link for inodeA.
rm the link, add inodeA to orphan_dir again
When orphan_scan work start, it calls ocfs2_queue_orphans() to do
the main work. It first tranverses entrys in orphan_dir, linking
all inodes in this orphan_dir to a list look like this:
inodeA->inodeB->...->inodeA
When tranvering this list, it will fall into loop, calling iput() again and again. And finally trigger BUG_ON(inode->i_state & I_CLEAR).
--- fs/ocfs2/namei.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
fs/ocfs2/namei.c +13 -0
@@ -644,6 +644,7 @@ static int ocfs2_link(struct dentry *old_dentry,struct ocfs2_super *osb =OCFS2_SB (dir->i_sb);struct ocfs2_dir_lookup_result lookup = {NULL , };sigset_t oldset; +u64 old_de_ino; trace_ocfs2_link((unsigned long long)OCFS2_I(inode)->ip_blkno, old_dentry->d_name.len, old_dentry->d_name.name,
@@ -666,6 +667,18 @@ static int ocfs2_link(struct dentry *old_dentry, goto out; } + err =ocfs2_lookup_ino_from_name (dir, old_dentry->d_name.name, + old_dentry->d_name.len, &old_de_ino); +if (err) { + err = -ENOENT ; + goto out; + } + +if (old_de_ino !=OCFS2_I (inode)->ip_blkno) { + err = -ENOENT ; + goto out; + } + err =ocfs2_check_dir_for_entry (dir, dentry->d_name.name, dentry->d_name.len);if (err)
Signature · 1 line
1.8.4.3