Skip to contentSkip to conversation

osm_trap_rcv.c: fix race condition during sweep

PATCH New Hal Rosenstock 1 participant 1 message Dec 30, 2013 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 osm_trap_rcv.c: fix race condition during sweep

From: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/[email protected]>

If SM receives trap 128 from a physp it didn't discover yet, it will crash.

---
 opensm/osm_trap_rcv.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
opensm/osm_trap_rcv.c +2 -1
index 72df5db..d5f646f 100644
@@ -568,7 +568,8 @@ check_sweep:
 	if (osm_log_is_active_v2(sm->p_log, OSM_LOG_INFO, FILE_ID)) {
 		if (ib_notice_is_generic(p_ntci) &&
 		    cl_ntoh16(p_ntci->g_or_v.generic.trap_num) == SM_LINK_STATE_CHANGED_TRAP) {
-			p_path = osm_physp_get_dr_path_ptr(p_physp);
+			p_path = (p_physp) ?
+			    osm_physp_get_dr_path_ptr(p_physp) : NULL;
 			if (p_path) {
 				n = sprintf(buf, "SM class trap %u: ",
 					    cl_ntoh16(p_ntci->g_or_v.generic.trap_num));
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html