fimc-lite.c: compile warning indicates bug

Hi Sylwester,

I just did a quick build with the latest set of commits and I found this warning:

.../media-git/drivers/media/platform/exynos4-is/fimc-lite.c: In function 'fimc_lite_probe':
.../media-git/drivers/media/platform/exynos4-is/fimc-lite.c:1583:1: warning: label 'err_sd' defined but not used [-Wunused-label]
err_sd:
^

As far as I can tell err_sd should certainly be used to do proper cleanup. Can you check the code and prepare a patch?

Hi Hans,

Quoted 10 lines · Hans Verkuil

Hi Sylwester,

I just did a quick build with the latest set of commits and I found this warning:

.../media-git/drivers/media/platform/exynos4-is/fimc-lite.c: In function 'fimc_lite_probe':
.../media-git/drivers/media/platform/exynos4-is/fimc-lite.c:1583:1: warning: label 'err_sd' defined but not used [-Wunused-label]
err_sd:
^

Quoted 2 lines

As far as I can tell err_sd should certainly be used to do proper cleanup. Can you check the code and prepare a patch?

Yes, I also noticed it in the media daily builds. It's a rebase error, unfortunately the mainline driver is now far behind our internal code. I will prepare a patch to fix this as soon as possible.