cppcheck mentions format string error
heise.de reported about a security flaw in xorg-server found by cppcheck - so I just gave it a try.
It reports :
~/devel/trinity $ cppcheck ./ --force --quiet
[devices.c:90]: (warning) %a in format string (no. 2) requires 'float *' but the argument type is 'char * *'.
Is it correct ?
Signature · 3 lines
MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
Quoted 9 lines · Toralf Förster
heise.de reported about a security flaw in xorg-server found by cppcheck - so I just gave it a try.
It reports :
~/devel/trinity $ cppcheck ./ --force --quiet
[devices.c:90]: (warning) %a in format string (no. 2) requires 'float *' but the argument type is 'char * *'.Is it correct ?
no. Looks like it doesn't understand the gnu %as extension, and thinks it's %a followed by 's'.
That extension isn't C99, but given portability isn't really a goal for trinity, I'm not overly bothered by it.
Dave
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Quoted 13 lines · Dave Jones
Quoted 11 lines · Toralf Förster
heise.de reported about a security flaw in xorg-server found by cppcheck - so I just gave it a try.
It reports :
~/devel/trinity $ cppcheck ./ --force --quiet [devices.c:90]:
(warning) %a in format string (no. 2) requires 'float *' but the argument type is 'char * *'.Is it correct ?
Quoted 9 lines
no. Looks like it doesn't understand the gnu %as extension, and thinks it's %a followed by 's'.
That extension isn't C99, but given portability isn't really a goal for trinity, I'm not overly bothered by it.
Dave
ok
FWIW I created an enhancement request for cppcheck :
Ticket URL: <http://sourceforge.net/apps/trac/cppcheck/ticket/5329>
- --
MfG/Sincerely
Toralf Förster
pgp finger print:1A37 6F99 4A9D 026F 13E2 4DCF C4EA CDDE 0076 E94E -----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlLNqEkACgkQxOrN3gB26U5kggD+IB2GXXByWJhXuQxZ/KBLpNQk 8uKd0/estsOegrJ9G/kA/2e4sCfDRL0OZlvOSqYPgtQFXiikQDf5ne5jo0ZkPtVg =EP9s
-----END PGP SIGNATURE-----
Quoted 20 lines · Toralf Förster
Quoted 19 lines · Dave Jones
Quoted 11 lines · Toralf Förster
heise.de reported about a security flaw in xorg-server found by cppcheck - so I just gave it a try.
It reports :
~/devel/trinity $ cppcheck ./ --force --quiet [devices.c:90]:
(warning) %a in format string (no. 2) requires 'float *' but the argument type is 'char * *'.Is it correct ?
no. Looks like it doesn't understand the gnu %as extension, and thinks it's %a followed by 's'.
That extension isn't C99, but given portability isn't really a goal for trinity, I'm not overly bothered by it.
Quoted 8 lines
Quoted 3 lines
Dave
ok
FWIW I created an enhancement request for cppcheck :
Ticket URL: <http://sourceforge.net/apps/trac/cppcheck/ticket/5329>
I'm not sure why I never noticed before, but after upgrading some packages this last week, suddenly gcc and llvm are both warning about it. After filing a bug on what I thought was a gcc bug, Jakub suggested switching to %ms, which should make things happier, including cppcheck.
strange.
Dave