Skip to contentSkip to conversation

ixgbe: set driver_max_VFs should be done before enabling SRIOV

PATCH New ethan zhao 1 participant 1 message Jan 16, 2014

Subsystems (3)
lore
Share & tools
lore

ethan zhao

author
#0 lore raw

PATCH v4 2/2 ixgbe: set driver_max_VFs should be done before enabling SRIOV

commit 43dc4e01 Limit number of reported VFs to device specific value It doesn't work and always returns -EBUSY because VFs ware already enabled.

ixgbe_enable_sriov()

        pci_enable_sriov()
                sriov_enable()
                {
                ... ..
                iov->ctrl |= PCI_SRIOV_CTRL_VFE | PCI_SRIOV_CTRL_MSE;
                pci_cfg_access_lock(dev);
                ... ...
                }

pci_sriov_set_totalvfs()
{
... ...
if (dev->sriov->ctrl & PCI_SRIOV_CTRL_VFE)

                return -EBUSY;

...
}

So should set driver_max_VFs with pci_sriov_set_totalvfs() before enable VFs with ixgbe_enable_sriov().

V2: revised for net-next tree.
V4: remove one signoff of two.

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +1 -1
index bea2cec..6e6af0d 100644
@@ -7972,8 +7972,8 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
     /* Mailbox */
     ixgbe_init_mbx_params_pf(hw);
     memcpy(&hw->mbx.ops, ii->mbx_ops, sizeof(hw->mbx.ops));
-    ixgbe_enable_sriov(adapter);
     pci_sriov_set_totalvfs(pdev, IXGBE_MAX_VFS_DRV_LIMIT);
+    ixgbe_enable_sriov(adapter);
 skip_sriov:
 
 #endif
Signature · 1 line
1.7.1