Skip to contentSkip to conversation

U-Boot DWC2 unused variables

U-Boot Stephen Warren 2 participants 2 messages Feb 4, 2014 – Feb 10, 2014

lore
Share & tools
lore
#0 lore raw

Oleksandr,

Thanks for the quick response on the s-o-b lines. Another question: The compiler is complaining about hprt0 being written but then not used in the functions below. I assume the second parameter passed to dwc_write_reg32() should be hprt0.d32 rather than val?

Quoted 23 lines

void dwc_otg_set_prtpower(dwc_otg_core_if_t * core_if, uint32_t val)

{
	hprt0_data_t hprt0;
	hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
	hprt0.b.prtpwr = val;
	dwc_write_reg32(core_if->host_if->hprt0, val);
}

void dwc_otg_set_prtsuspend(dwc_otg_core_if_t * core_if, uint32_t val)

{
	hprt0_data_t hprt0;
	hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
	hprt0.b.prtsusp = val;
	dwc_write_reg32(core_if->host_if->hprt0, val);
}

void dwc_otg_set_prtresume(dwc_otg_core_if_t * core_if, uint32_t val)

{
	hprt0_data_t hprt0;
	hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
	hprt0.b.prtres = val;
	dwc_write_reg32(core_if->host_if->hprt0, val);
}
#1 lore raw
Quoted 6 lines · Stephen Warren

Oleksandr,

Thanks for the quick response on the s-o-b lines. Another question: The compiler is complaining about hprt0 being written but then not used in the functions below. I assume the second parameter passed to dwc_write_reg32() should be hprt0.d32 rather than val?

Yes, I think you're right. My mistake.

Quoted 25 lines
Quoted 24 lines

void dwc_otg_set_prtpower(dwc_otg_core_if_t * core_if, uint32_t val)

{
	hprt0_data_t hprt0;
	hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
	hprt0.b.prtpwr = val;
	dwc_write_reg32(core_if->host_if->hprt0, val);
}

void dwc_otg_set_prtsuspend(dwc_otg_core_if_t * core_if, uint32_t val)

{
	hprt0_data_t hprt0;
	hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
	hprt0.b.prtsusp = val;
	dwc_write_reg32(core_if->host_if->hprt0, val);
}

void dwc_otg_set_prtresume(dwc_otg_core_if_t * core_if, uint32_t val)

{
	hprt0_data_t hprt0;
	hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
	hprt0.b.prtres = val;
	dwc_write_reg32(core_if->host_if->hprt0, val);
}