Skip to contentSkip to conversation

osm_qos.c: Fix possible seg fault

PATCH New Hal Rosenstock 1 participant 1 message Feb 4, 2014 InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 osm_qos.c: Fix possible seg fault

From: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/[email protected]>

Pointed-out-by Jens Domke <[email protected]>

Introduced by commit 1633550020087f3296dbc2f7b1dd533cd83a6398

If force_update is set, p_tbl isn't initialized

Signed-off-by Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 opensm/osm_qos.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
opensm/osm_qos.c +3 -2
index f55a509..b174f66 100644
@@ -248,8 +248,9 @@ static ib_api_status_t sl2vl_update_table(osm_sm_t * sm, osm_physp_t * p,
 		tbl.raw_vl_by_sl[i] = (vl1 << 4) | vl2;
 	}
 
-	if (!force_update && (p_tbl = osm_physp_get_slvl_tbl(p, in_port)) &&
-	    !memcmp(p_tbl, &tbl, sizeof(tbl)))
+	p_tbl = osm_physp_get_slvl_tbl(p, in_port);
+
+	if (!force_update && !memcmp(p_tbl, &tbl, sizeof(tbl)))
 		return IB_SUCCESS;
 
 	p_mad = osm_qos_mad_create(sm, p, sizeof(tbl), (uint8_t *) & tbl,
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html