pciehp: Enable link state change notifications
PATCH v4 3/8 pciehp: Enable link state change notifications
Enabled the Link state notifications unconditionaly. Enable the presence detection notification only if attention button is absent. This was discussed at this thread:
http://marc.info/?t=138611014300001&r=1&w=2
Signed-off-by Rajat Jain <[email protected]>
Signed-off-by Rajat Jain <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
--- drivers/pci/hotplug/pciehp_hpc.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/pci/hotplug/pciehp_hpc.c +11 -2
@@ -600,9 +600,17 @@ void pcie_enable_notification(struct controller *ctrl)* when it is cleared in the interrupt service routine, and * next power fault detected interrupt was notified again. */ - cmd =PCI_EXP_SLTCTL_PDCE ; + +/* +* Always enable link events: thus link-up and link-down shall +* always be treated as hotplug and unplug respectively. Enable +* presence detect only if Attention Button is not present. +*/ + cmd =PCI_EXP_SLTCTL_DLLSCE ;if (ATTN_BUTTN (ctrl)) cmd |=PCI_EXP_SLTCTL_ABPE ; +else + cmd |=PCI_EXP_SLTCTL_PDCE ;if (MRL_SENS (ctrl)) cmd |=PCI_EXP_SLTCTL_MRLSCE ;if (!pciehp_poll_mode)
@@ -610,7 +618,8 @@ void pcie_enable_notification(struct controller *ctrl) mask = (PCI_EXP_SLTCTL_PDCE |PCI_EXP_SLTCTL_ABPE |PCI_EXP_SLTCTL_MRLSCE |PCI_EXP_SLTCTL_PFDE | -PCI_EXP_SLTCTL_HPIE |PCI_EXP_SLTCTL_CCIE ); +PCI_EXP_SLTCTL_HPIE |PCI_EXP_SLTCTL_CCIE | +PCI_EXP_SLTCTL_DLLSCE );pcie_write_cmd (ctrl, cmd, mask); }
Signature · 1 line
1.7.9.5