Skip to contentSkip to conversation

mutex: Give spinners a chance to spin_on_owner if need_resched() triggered while queued

RFC PATCH Daniel J Blueman 1 participant 1 message Feb 6, 2014

lore
Share & tools
lore
#0 lore raw
Quoted 18 lines · Peter Zijlstra
Quoted 3 lines · Waiman Long

I have an alternative way of breaking out of the MCS lock waiting queue when need_resched() is set. I overload the locked flag to indicate a skipped node if negative.

I'm not quite seeing how it works (then again, I've not really read the patch carefully).

Suppose you break out; at that point you get queued and go to sleep. Suppose you got woken up while you MCS entry is still 'pending' and magically win the race and acquire the lock.

At that point your MCS entry can be re-used while its still part of the list.

Its a fantastically small race window, but I don't see anything that makes it impossible.

Quoted 6 lines
Quoted 2 lines

I run the patch through the AIM7 high-systime workload on a 4-socket server and it seemed to run fine.

How do people run this AIM7 piece of shit? I let it run for over an hour and it generated exactly 0 numbers, it just sits there eating cpu-time and creating a racket from my pantry.

Without any better advice, I was building the OSDL AIM7 [1], tweaking DISKDIR in data/reaim.config and running (eg on a 384-core setup):

$ src/reaim -c data/reaim.config -f data/workfile.compute -i 16 -e 384

Thanks,
Daniel

[1] http://sourceforge.net/projects/re-aim-7/

Signature · 2 lines
Daniel J Blueman
Principal Software Engineer, Numascale