Skip to contentSkip to conversation

Couple of questions about details of the RT patch

DISCUSSION Corey Minyard 3 participants 3 messages Feb 6, 2014 – Feb 13, 2014

lore
Share & tools
lore
#0 lore raw

I was looking over the RT patch and I had a couple of questions:

Is there a reason that the PREEMPT_LAZY code is not ifdef-ed out when PREEMPT_LAZY is disabled. I can't see a reason to leave it in, it's just dead code at that point. I'd be happy to do a patch to fix this.

Why does preempt_disable_rt() become a barrier when PREEMPT_RT is disabled? Why isn't it just nothing?

Thanks,

-corey

#1 lore raw
Quoted 8 lines · Corey Minyard

I was looking over the RT patch and I had a couple of questions:

Is there a reason that the PREEMPT_LAZY code is not ifdef-ed out when PREEMPT_LAZY is disabled. I can't see a reason to leave it in, it's just dead code at that point. I'd be happy to do a patch to fix this.

Why does preempt_disable_rt() become a barrier when PREEMPT_RT is disabled? Why isn't it just nothing?

Because I'm a lazy bastard and I fundamentaly hate #ifdefs :)

Thanks,

tglx

#2 lore raw

PATCHES for 3.14

Guys and Mainteiners, throw 3.12 and other non LTS version, please enjoy a 3.14 kernel. How will release, we will be "stable" patches :D