regression(ti platforms): next-20140210 (ehci?)

DISCUSSION Nishanth Menon 5 participants 11 messages Feb 10, 2014 – Feb 11, 2014 2 messages not in the archive Linux-next tree

lore

Share & tools

lore

Nishanth Menon

author

2014-02-10 15:59 UTC #0 lore raw

Hi,

A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:

Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)

next-20140210-multi_v7_defconfig

 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2zYHdPb94
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2UChLyzSE
 3: am3517-evm:  Boot FAIL: http://slexy.org/raw/s20Br9XLO1

around ehci

4: am37x-evm: Boot FAIL: http://slexy.org/raw/s20mVz9Wc7
around ehci

5: am43xx-epos: Boot PASS: http://slexy.org/raw/s2byveBYtT
6: BeagleBoard-XM: Boot FAIL: http://slexy.org/raw/s21sOgJNwK
around ehci

7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2ovVNAmO7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s217qwaXsM
10: ldp: Boot FAIL: http://slexy.org/raw/s203IvjE23
around ehci

11: PandaBoard-ES: Boot FAIL: http://slexy.org/raw/s2NvkRx2YJ
around ehci

12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot FAIL: http://slexy.org/raw/s21cwW7PqH

around ehci

14: sdp4430: Boot PASS: http://slexy.org/raw/s2hL39Pyl9
15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s20UsDeuVB
TOTAL = 15 boards, Booted Boards = 7, No Boot boards = 8

next-20140207-multi_v7_defconfig

 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2yo795okf
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2TfAOi6XP
 3: am3517-evm:  Boot PASS: http://slexy.org/raw/s21sKT3pFN
 4:  am37x-evm:  Boot PASS: http://slexy.org/raw/s21nCiNjAR

5: am43xx-epos: Boot PASS: http://slexy.org/raw/s21uEu69lC
6: BeagleBoard-XM: Boot PASS: http://slexy.org/raw/s21SklkJs7
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s21aYZvPl7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s20soGBbYz
10: ldp: Boot PASS: http://slexy.org/raw/s20lDIIwgN
11: PandaBoard-ES: Boot PASS: http://slexy.org/raw/s2a5NWPUtE

12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot PASS: http://slexy.org/raw/s2osagMVWZ
14:    sdp4430:  Boot PASS: http://slexy.org/raw/s2NxmpHFaW

15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s2PMcXzAUP
TOTAL = 15 boards, Booted Boards = 13, No Boot boards = 2

in comparison:
v3.14-rc2-multi_v7_defconfig

 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2NWCJQczI
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2566ZAl5d
 3: am3517-evm:  Boot PASS: http://slexy.org/raw/s2msKg3ZQ9
 4:  am37x-evm:  Boot PASS: http://slexy.org/raw/s2898HemYQ

5: am43xx-epos: Boot PASS: http://slexy.org/raw/s20ajDkVgM
6: BeagleBoard-XM: Boot PASS: http://slexy.org/raw/s20YmD8SSG
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2sXDV7x0T
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s21Zz8NJrj
10: ldp: Boot PASS: http://slexy.org/raw/s21NANMvTx
11: PandaBoard-ES: Boot PASS: http://slexy.org/raw/s20NER4paD

12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot PASS: http://slexy.org/raw/s2WCHUl033
14:    sdp4430:  Boot PASS: http://slexy.org/raw/s21ySru6J1

15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s2kztuFoSu
TOTAL = 15 boards, Booted Boards = 13, No Boot boards = 2

Signature · 2 lines

Regards,
Nishanth Menon

Roger Quadros

2014-02-10 16:11 UTC #1 lore raw

Nishant,

Quoted 8 lines · Nishanth Menon

Hi,
A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:
Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)

I'll take a look what's happening.
Funny thing is that am335x doesn't even have an EHCI controller.

cheers,
-roger

Quoted 68 lines

next-20140210-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2zYHdPb94
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2UChLyzSE
 3: am3517-evm:  Boot FAIL: http://slexy.org/raw/s20Br9XLO1
around ehci
4: am37x-evm: Boot FAIL: http://slexy.org/raw/s20mVz9Wc7
around ehci
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s2byveBYtT
6: BeagleBoard-XM: Boot FAIL: http://slexy.org/raw/s21sOgJNwK
around ehci
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2ovVNAmO7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s217qwaXsM
10: ldp: Boot FAIL: http://slexy.org/raw/s203IvjE23
around ehci
11: PandaBoard-ES: Boot FAIL: http://slexy.org/raw/s2NvkRx2YJ
around ehci
12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot FAIL: http://slexy.org/raw/s21cwW7PqH
around ehci
14: sdp4430: Boot PASS: http://slexy.org/raw/s2hL39Pyl9
15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s20UsDeuVB
TOTAL = 15 boards, Booted Boards = 7, No Boot boards = 8
next-20140207-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2yo795okf
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2TfAOi6XP
 3: am3517-evm:  Boot PASS: http://slexy.org/raw/s21sKT3pFN
 4:  am37x-evm:  Boot PASS: http://slexy.org/raw/s21nCiNjAR
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s21uEu69lC
6: BeagleBoard-XM: Boot PASS: http://slexy.org/raw/s21SklkJs7
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s21aYZvPl7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s20soGBbYz
10: ldp: Boot PASS: http://slexy.org/raw/s20lDIIwgN
11: PandaBoard-ES: Boot PASS: http://slexy.org/raw/s2a5NWPUtE
12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot PASS: http://slexy.org/raw/s2osagMVWZ
14:    sdp4430:  Boot PASS: http://slexy.org/raw/s2NxmpHFaW
15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s2PMcXzAUP
TOTAL = 15 boards, Booted Boards = 13, No Boot boards = 2
in comparison:
v3.14-rc2-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2NWCJQczI
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2566ZAl5d
 3: am3517-evm:  Boot PASS: http://slexy.org/raw/s2msKg3ZQ9
 4:  am37x-evm:  Boot PASS: http://slexy.org/raw/s2898HemYQ
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s20ajDkVgM
6: BeagleBoard-XM: Boot PASS: http://slexy.org/raw/s20YmD8SSG
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2sXDV7x0T
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s21Zz8NJrj
10: ldp: Boot PASS: http://slexy.org/raw/s21NANMvTx
11: PandaBoard-ES: Boot PASS: http://slexy.org/raw/s20NER4paD
12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot PASS: http://slexy.org/raw/s2WCHUl033
14:    sdp4430:  Boot PASS: http://slexy.org/raw/s21ySru6J1
15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s2kztuFoSu
TOTAL = 15 boards, Booted Boards = 13, No Boot boards = 2

Nishanth Menon

author

2014-02-10 16:22 UTC #2 lore raw

Quoted 11 lines · Roger Quadros

Quoted 8 lines · Nishanth Menon
Hi,
A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:
Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)
I'll take a look what's happening.

Thanks.

Quoted 1 line

Funny thing is that am335x doesn't even have an EHCI controller.

I dont think any of the am335x platforms fail - just OMAP3,4 platforms which do fail.

Side note: all platforms are tested with device tree boot (not the legacy boot).

Signature · 2 lines

Regards,
Nishanth Menon

A message that is not in the archive (sent off-list or not yet received): [email protected]

Roger Quadros

2014-02-10 17:50 UTC #4 lore raw

+devicetree

Quoted 22 lines · Nishanth Menon

Hi,
A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:
Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)
next-20140210-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2zYHdPb94
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2UChLyzSE
 3: am3517-evm:  Boot FAIL: http://slexy.org/raw/s20Br9XLO1
around ehci
4: am37x-evm: Boot FAIL: http://slexy.org/raw/s20mVz9Wc7
around ehci
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s2byveBYtT
6: BeagleBoard-XM: Boot FAIL: http://slexy.org/raw/s21sOgJNwK
around ehci

Quoted 8 lines

7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2ovVNAmO7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s217qwaXsM
10: ldp: Boot FAIL: http://slexy.org/raw/s203IvjE23
around ehci
11: PandaBoard-ES: Boot FAIL: http://slexy.org/raw/s2NvkRx2YJ
around ehci

I think the problem is that ehci-platform driver gets loaded instead of ehci-omap.

In the DT node we have compatible ids for both. e.g. for omap4.dtsi

                        usbhsehci: ehci@4a064c00 {
                                compatible = "ti,ehci-omap", "usb-ehci";
                                reg = <0x4a064c00 0x400>;
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
                        };

Shouldn't ehci-omap driver be getting a higher priority than usb-ehci?

A quick fix would be to eliminate "usb-ehci" from the DT node of all failing platforms.

cheers,
-roger

Quoted 40 lines

12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot FAIL: http://slexy.org/raw/s21cwW7PqH
around ehci
14: sdp4430: Boot PASS: http://slexy.org/raw/s2hL39Pyl9
15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s20UsDeuVB
TOTAL = 15 boards, Booted Boards = 7, No Boot boards = 8
next-20140207-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2yo795okf
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2TfAOi6XP
 3: am3517-evm:  Boot PASS: http://slexy.org/raw/s21sKT3pFN
 4:  am37x-evm:  Boot PASS: http://slexy.org/raw/s21nCiNjAR
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s21uEu69lC
6: BeagleBoard-XM: Boot PASS: http://slexy.org/raw/s21SklkJs7
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s21aYZvPl7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s20soGBbYz
10: ldp: Boot PASS: http://slexy.org/raw/s20lDIIwgN
11: PandaBoard-ES: Boot PASS: http://slexy.org/raw/s2a5NWPUtE
12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot PASS: http://slexy.org/raw/s2osagMVWZ
14:    sdp4430:  Boot PASS: http://slexy.org/raw/s2NxmpHFaW
15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s2PMcXzAUP
TOTAL = 15 boards, Booted Boards = 13, No Boot boards = 2
in comparison:
v3.14-rc2-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2NWCJQczI
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2566ZAl5d
 3: am3517-evm:  Boot PASS: http://slexy.org/raw/s2msKg3ZQ9
 4:  am37x-evm:  Boot PASS: http://slexy.org/raw/s2898HemYQ
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s20ajDkVgM
6: BeagleBoard-XM: Boot PASS: http://slexy.org/raw/s20YmD8SSG
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2sXDV7x0T
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s21Zz8NJrj
10: ldp: Boot PASS: http://slexy.org/raw/s21NANMvTx
11: PandaBoard-ES: Boot PASS: http://slexy.org/raw/s20NER4paD

Quoted 6 lines

12:    sdp2430:  Boot FAIL: expected (v6 platform)
13:    sdp3430:  Boot PASS: http://slexy.org/raw/s2WCHUl033
14:    sdp4430:  Boot PASS: http://slexy.org/raw/s21ySru6J1
15: OMAP5432uEVM: Boot PASS: http://slexy.org/raw/s2kztuFoSu
TOTAL = 15 boards, Booted Boards = 13, No Boot boards = 2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Nishanth Menon

author

2014-02-10 18:02 UTC #5 lore raw

Quoted 2 lines · Roger Quadros

+devicetree

[...]

Quoted 9 lines

In the DT node we have compatible ids for both. e.g. for omap4.dtsi

                        usbhsehci: ehci@4a064c00 {
                                compatible = "ti,ehci-omap", "usb-ehci";
                                reg = <0x4a064c00 0x400>;
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
                        };

Quoted 3 lines

Shouldn't ehci-omap driver be getting a higher priority than usb-ehci?
A quick fix would be to eliminate "usb-ehci" from the DT node of all failing platforms.

If the driver is not compatible with "usb-ehci", not sure why do we even state that in dts node?

Signature · 2 lines

Regards,
Nishanth Menon

Roger Quadros

2014-02-10 18:16 UTC #6 lore raw

Quoted 13 lines · Nishanth Menon

Quoted 2 lines · Roger Quadros

+devicetree

[...]

Quoted 9 lines

In the DT node we have compatible ids for both. e.g. for omap4.dtsi

                        usbhsehci: ehci@4a064c00 {
                                compatible = "ti,ehci-omap", "usb-ehci";
                                reg = <0x4a064c00 0x400>;
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
                        };

Quoted 8 lines

Quoted 3 lines
Shouldn't ehci-omap driver be getting a higher priority than usb-ehci?
A quick fix would be to eliminate "usb-ehci" from the DT node of all failing platforms.
If the driver is not compatible with "usb-ehci", not sure why do we even state that in dts node?

I'm not sure either. Let's get rid of it.

Patch to fix the reported issue.
http://article.gmane.org/gmane.linux.drivers.devicetree/61204

cheers,
-roger

Kevin Hilman

2014-02-10 18:28 UTC #7 lore raw

In reply to Roger Quadros

Quoted 45 lines · Roger Quadros

+devicetree
Quoted 22 lines · Nishanth Menon
Hi,
A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:
Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)
next-20140210-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2zYHdPb94
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2UChLyzSE
 3: am3517-evm:  Boot FAIL: http://slexy.org/raw/s20Br9XLO1
around ehci
4: am37x-evm: Boot FAIL: http://slexy.org/raw/s20mVz9Wc7
around ehci
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s2byveBYtT
6: BeagleBoard-XM: Boot FAIL: http://slexy.org/raw/s21sOgJNwK
around ehci
Quoted 8 lines
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2ovVNAmO7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s217qwaXsM
10: ldp: Boot FAIL: http://slexy.org/raw/s203IvjE23
around ehci
11: PandaBoard-ES: Boot FAIL: http://slexy.org/raw/s2NvkRx2YJ
around ehci
I think the problem is that ehci-platform driver gets loaded instead of ehci-omap.
In the DT node we have compatible ids for both. e.g. for omap4.dtsi
                        usbhsehci: ehci@4a064c00 {
                                compatible = "ti,ehci-omap", "usb-ehci";
                                reg = <0x4a064c00 0x400>;
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
                        };

Quoted 3 lines

Shouldn't ehci-omap driver be getting a higher priority than usb-ehci?
A quick fix would be to eliminate "usb-ehci" from the DT node of all failing platforms.

I can confirm that simply remvoing usb-ehci from omap[34].dtsi nodes fixed the problem for me on 3530/overo, 3730/beagle-xM and 4460/panda-es. But I don't think that's the right fix. First we have to figure out why ehci-omap stopped getting loaded first.

Kevin

Nishanth Menon

author

2014-02-10 19:33 UTC #8 lore raw

Quoted 47 lines · Kevin Hilman

Quoted 45 lines · Roger Quadros
+devicetree
Quoted 22 lines · Nishanth Menon
Hi,
A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:
Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)
next-20140210-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2zYHdPb94
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2UChLyzSE
 3: am3517-evm:  Boot FAIL: http://slexy.org/raw/s20Br9XLO1
around ehci
4: am37x-evm: Boot FAIL: http://slexy.org/raw/s20mVz9Wc7
around ehci
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s2byveBYtT
6: BeagleBoard-XM: Boot FAIL: http://slexy.org/raw/s21sOgJNwK
around ehci
Quoted 8 lines
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2ovVNAmO7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s217qwaXsM
10: ldp: Boot FAIL: http://slexy.org/raw/s203IvjE23
around ehci
11: PandaBoard-ES: Boot FAIL: http://slexy.org/raw/s2NvkRx2YJ
around ehci
I think the problem is that ehci-platform driver gets loaded instead of ehci-omap.
In the DT node we have compatible ids for both. e.g. for omap4.dtsi
                        usbhsehci: ehci@4a064c00 {
                                compatible = "ti,ehci-omap", "usb-ehci";
                                reg = <0x4a064c00 0x400>;
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
                        };

Quoted 8 lines

Quoted 3 lines
Shouldn't ehci-omap driver be getting a higher priority than usb-ehci?
A quick fix would be to eliminate "usb-ehci" from the DT node of all failing platforms.
I can confirm that simply remvoing usb-ehci from omap[34].dtsi nodes fixed the problem for me on 3530/overo, 3730/beagle-xM and 4460/panda-es. But I don't think that's the right fix. First we have to figure out why ehci-omap stopped getting loaded first.

Wont that depend on driver probe order? of_match_device is fairly simple compatible walk through without looking at other drivers which might also be compatible, but not yet probed?

The issue started I think with the following patch getting merged:
ehci-platform: Add support for clks and phy passed through devicetree some version of http://www.spinics.net/lists/linux-usb/msg101061.html
introduced { .compatible = "usb-ehci", },

Now, in the build we have two drivers which dts claims compatibility with, but only 1 driver actually works (drivers/usb/host/ehci-omap.c) for the platform. Thinking that way, in fact, the current compatibility even matches drivers/usb/host/ehci-ppc-of.c which obviously wont work either.

Signature · 2 lines

Regards,
Nishanth Menon

Kevin Hilman

2014-02-11 01:07 UTC #9 lore raw

Quoted 57 lines · Nishanth Menon

Quoted 47 lines · Kevin Hilman
Quoted 45 lines · Roger Quadros
+devicetree
Quoted 22 lines · Nishanth Menon
Hi,
A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:
Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)
next-20140210-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2zYHdPb94
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2UChLyzSE
 3: am3517-evm:  Boot FAIL: http://slexy.org/raw/s20Br9XLO1
around ehci
4: am37x-evm: Boot FAIL: http://slexy.org/raw/s20mVz9Wc7
around ehci
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s2byveBYtT
6: BeagleBoard-XM: Boot FAIL: http://slexy.org/raw/s21sOgJNwK
around ehci
Quoted 8 lines
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2ovVNAmO7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s217qwaXsM
10: ldp: Boot FAIL: http://slexy.org/raw/s203IvjE23
around ehci
11: PandaBoard-ES: Boot FAIL: http://slexy.org/raw/s2NvkRx2YJ
around ehci
I think the problem is that ehci-platform driver gets loaded instead of ehci-omap.
In the DT node we have compatible ids for both. e.g. for omap4.dtsi
                        usbhsehci: ehci@4a064c00 {
                                compatible = "ti,ehci-omap", "usb-ehci";
                                reg = <0x4a064c00 0x400>;
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
                        };
Quoted 8 lines
Quoted 3 lines
Shouldn't ehci-omap driver be getting a higher priority than usb-ehci?
A quick fix would be to eliminate "usb-ehci" from the DT node of all failing platforms.
I can confirm that simply remvoing usb-ehci from omap[34].dtsi nodes fixed the problem for me on 3530/overo, 3730/beagle-xM and 4460/panda-es. But I don't think that's the right fix. First we have to figure out why ehci-omap stopped getting loaded first.

Quoted 8 lines

Wont that depend on driver probe order? of_match_device is fairly simple compatible walk through without looking at other drivers which might also be compatible, but not yet probed?
The issue started I think with the following patch getting merged:
ehci-platform: Add support for clks and phy passed through devicetree some version of http://www.spinics.net/lists/linux-usb/msg101061.html
introduced { .compatible = "usb-ehci", },

This is what I was getting at: an understanding of what caused the failue in the first place.

Quoted 5 lines

Now, in the build we have two drivers which dts claims compatibility with, but only 1 driver actually works (drivers/usb/host/ehci-omap.c) for the platform. Thinking that way, in fact, the current compatibility even matches drivers/usb/host/ehci-ppc-of.c which obviously wont work either.

Right, so I agree that it makes sense to remove a compatible string where there is no compatability, but a couple other things should happen here.

1) changelog should describe why this compatible string is in the omap dtsi files in first place.

2) investigation into the patch that introduced this change to double check it's not introducing other breakage as well.

Kevin

Nishanth Menon

author

2014-02-11 13:27 UTC #10 lore raw

Quoted 77 lines · Kevin Hilman

Quoted 57 lines · Nishanth Menon
Quoted 47 lines · Kevin Hilman
Quoted 45 lines · Roger Quadros
+devicetree
Quoted 22 lines · Nishanth Menon
Hi,
A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms:
Note: crane and sdp2430 are not expected to pass with multi_v7_defconfig (note: omap2plus_defconfig boot seems to be sane but USB is disabled there)
next-20140210-multi_v7_defconfig
 1: am335x-evm:  Boot PASS: http://slexy.org/raw/s2zYHdPb94
 2:  am335x-sk:  Boot PASS: http://slexy.org/raw/s2UChLyzSE
 3: am3517-evm:  Boot FAIL: http://slexy.org/raw/s20Br9XLO1
around ehci
4: am37x-evm: Boot FAIL: http://slexy.org/raw/s20mVz9Wc7
around ehci
5: am43xx-epos: Boot PASS: http://slexy.org/raw/s2byveBYtT
6: BeagleBoard-XM: Boot FAIL: http://slexy.org/raw/s21sOgJNwK
around ehci
Quoted 8 lines
7: BeagleBone-Black: Boot PASS: http://slexy.org/raw/s2ovVNAmO7
8: crane: No Image built - Missing platform support?:
9: dra7: Boot PASS: http://slexy.org/raw/s217qwaXsM
10: ldp: Boot FAIL: http://slexy.org/raw/s203IvjE23
around ehci
11: PandaBoard-ES: Boot FAIL: http://slexy.org/raw/s2NvkRx2YJ
around ehci
I think the problem is that ehci-platform driver gets loaded instead of ehci-omap.
In the DT node we have compatible ids for both. e.g. for omap4.dtsi
                        usbhsehci: ehci@4a064c00 {
                                compatible = "ti,ehci-omap", "usb-ehci";
                                reg = <0x4a064c00 0x400>;
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
                        };
Quoted 8 lines
Quoted 3 lines
Shouldn't ehci-omap driver be getting a higher priority than usb-ehci?
A quick fix would be to eliminate "usb-ehci" from the DT node of all failing platforms.
I can confirm that simply remvoing usb-ehci from omap[34].dtsi nodes fixed the problem for me on 3530/overo, 3730/beagle-xM and 4460/panda-es. But I don't think that's the right fix. First we have to figure out why ehci-omap stopped getting loaded first.
Quoted 8 lines
Wont that depend on driver probe order? of_match_device is fairly simple compatible walk through without looking at other drivers which might also be compatible, but not yet probed?
The issue started I think with the following patch getting merged:
ehci-platform: Add support for clks and phy passed through devicetree some version of http://www.spinics.net/lists/linux-usb/msg101061.html
introduced { .compatible = "usb-ehci", },
This is what I was getting at: an understanding of what caused the failue in the first place.
Quoted 5 lines
Now, in the build we have two drivers which dts claims compatibility with, but only 1 driver actually works (drivers/usb/host/ehci-omap.c) for the platform. Thinking that way, in fact, the current compatibility even matches drivers/usb/host/ehci-ppc-of.c which obviously wont work either.

Quoted 7 lines

Right, so I agree that it makes sense to remove a compatible string where there is no compatability, but a couple other things should happen here.
1) changelog should describe why this compatible string is in the omap dtsi files in first place.

Agreed: I had commented the same on
https://patchwork.kernel.org/patch/3621811/

Quoted 2 lines

2) investigation into the patch that introduced this change to double check it's not introducing other breakage as well.

discussion is now on the relevant patch generating the break:
http://marc.info/?t=139178752000003&r=1&w=2

Signature · 2 lines

Regards,
Nishanth Menon

A message that is not in the archive (sent off-list or not yet received): 7h38jq8nk9.fsf-4poPxKt068f/[email protected]

Alan Stern

2014-02-11 15:21 UTC #12 lore raw

Quoted 18 lines · Kevin Hilman

Quoted 4 lines
The issue started I think with the following patch getting merged:
ehci-platform: Add support for clks and phy passed through devicetree some version of http://www.spinics.net/lists/linux-usb/msg101061.html
introduced { .compatible = "usb-ehci", },
This is what I was getting at: an understanding of what caused the failue in the first place.
Quoted 5 lines
Now, in the build we have two drivers which dts claims compatibility with, but only 1 driver actually works (drivers/usb/host/ehci-omap.c) for the platform. Thinking that way, in fact, the current compatibility even matches drivers/usb/host/ehci-ppc-of.c which obviously wont work either.
Right, so I agree that it makes sense to remove a compatible string where there is no compatability, but a couple other things should happen here.

Quoted 5 lines

1) changelog should describe why this compatible string is in the omap dtsi files in first place.
2) investigation into the patch that introduced this change to double check it's not introducing other breakage as well.

Oddly enough, it was Roger who introduced this incorrect compatibility string in commit f17c89948dcd6 (ARM: dts: OMAP4: Add HS USB Host IP nodes). There is no explanation in the commit log of why the string is there.

We better remove it from all the files where it doesn't belong. Of course, this won't help existing hardware. It will still be necessary to change the compatibility string used for the generic platform drivers.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html