Skip to contentSkip to conversation

liblockdep fixes for v3.14

GIT PULL Sasha Levin 2 participants 2 messages Feb 12, 2014 – Feb 22, 2014

lore
Share & tools
lore
#0 lore raw

The following changes since commit 65370bdf881e20907e7a53abab9b8c0bc5f60a6b:

Merge branch 'linus' into core/locking (2014-02-02 09:43:20 +0100)

are available in the git repository at:

https://github.com/sashalevin/liblockdep.git liblockdep-fixes

for you to fetch changes up to 8a29727f2a02e3c2592ebb71c3b0216d0db8f141:

tools/liblockdep: Use realpath for srctree and objtree (2014-02-12 16:38:02 -0500)

----------------------------------------------------------------
Ira W. Snyder (3):
tools/liblockdep: Fix initialization code path tools/liblockdep: Fix include of asm/hash.h tools/liblockdep: Add include directory to allow tests to compile

Sasha Levin (2):
tools/liblockdep: Mark runtests.sh as executable tools/liblockdep: Add a stub for new rcu_is_watching

Wang Nan (1):
tools/liblockdep: Use realpath for srctree and objtree

 tools/lib/lockdep/Makefile             | 6 +++---
 tools/lib/lockdep/preload.c            | 2 +-
 tools/lib/lockdep/run_tests.sh         | 0
 tools/lib/lockdep/uinclude/asm/hash.h  | 6 ++++++
 tools/lib/lockdep/uinclude/linux/rcu.h | 5 +++++
 5 files changed, 15 insertions(+), 4 deletions(-)
 mode change 100644 => 100755 tools/lib/lockdep/run_tests.sh
 create mode 100644 tools/lib/lockdep/uinclude/asm/hash.h
Acked-by Sasha Levin
#1 lore raw
Quoted 3 lines · Sasha Levin

The following changes since commit 65370bdf881e20907e7a53abab9b8c0bc5f60a6b:

Merge branch 'linus' into core/locking (2014-02-02 09:43:20 +0100)

That's not a suitable base commit for upstream fixes (because it brings in tip:core/locking changes destined for v3.15!) - please use tip:core/urgent or one of Linus's -rc's.

Also, I found some more commit log problems.

1)

This:

Is redundant - skip the Acked-by.

2)

This:

[sasha: Modified subject]

should in general be:

[ Modified subject. ]

Because it's obvious from the placement of the bracketed line that the comment is from you, no need to prefix it with 'sasha:'.

But ... more importantly, small commit log edits are typical (and expected) from maintainers - I do it for 99% of the patches that I apply, so please only add such comments if it goes outside the usual pattern:

- if you've written a completely new changelog (nice from you)

- or if you've resolved conflicts when applying the patch or actually changed the code logic compared to what was submitted (which should always be declared).

Thanks,

Ingo