mm/memory-failure.c: fix memory leak in successful soft offlining

request for stable inclusion Xishi Qiu 2 participants 2 messages Feb 13, 2014 Memory management

lore

Share & tools

lore

Xishi Qiu

author

2014-02-13 01:42 UTC #0 lore raw

Hi Naoya or Greg,

f15bdfa802bfa5eb6b4b5a241b97ec9fa1204a35 mm/memory-failure.c: fix memory leak in successful soft offlining

This patche look applicable to stable-3.10.
After a successful page migration by soft offlining, the source page is not properly freed and it's never reusable even if we unpoison it afterward. This is caused by the race between freeing page and setting PG_hwpoison.
It was built successful for me. What do you think?

Thanks,
Xishi Qiu

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Naoya Horiguchi

2014-02-13 20:32 UTC #1 lore raw

Hello Xishi,

Quoted 11 lines · Xishi Qiu

Hi Naoya or Greg,
f15bdfa802bfa5eb6b4b5a241b97ec9fa1204a35 mm/memory-failure.c: fix memory leak in successful soft offlining
This patche look applicable to stable-3.10.
After a successful page migration by soft offlining, the source page is not properly freed and it's never reusable even if we unpoison it afterward. This is caused by the race between freeing page and setting PG_hwpoison.
It was built successful for me. What do you think?

I agree to sending this patch into the stable. I should've added "cc: stable" tag in patch description.

Thanks,
Naoya Horiguchi