add PCI IDs so RME32 and RME96 drivers build
PATCH 1/1 add PCI IDs so RME32 and RME96 drivers build
While doing an allyesconfig build, I noticed that the commit
commit 8cdfd2519c6c9a1e6057dc5970b2542b35895738
Author: Takashi Iwai <[email protected]>
Date: Wed Sep 7 14:08:11 2005 +0200
[ALSA] Remove superfluous PCI ID definitions
broke the RME32 and RME96 drivers, since the PCI IDs they use seem to have changed names. Here's a patch to fix this -- compile tested only, since I have no idea what the hardware even is.
Fix the build of the RME32 and RME96 drivers by having them use the PCI_DEVICE_ID_RME_xxx names defined in <linux/pci_ids.h> instead of the PCI_DEVICE_ID_xxx names that they used to define themselves.
Also fix the typo in the id PCI_DEVICE_IDRME__DIGI96_8_PAD_OR_PST so the name is PCI_DEVICE_ID_RME_DIGI96_8_PAD_OR_PST.
include/linux/pci_ids.h +1 -1
@@ -1355,7 +1355,7 @@#define PCI_DEVICE_ID_RME_DIGI96 0x3fc0#define PCI_DEVICE_ID_RME_DIGI96_8 0x3fc1#define PCI_DEVICE_ID_RME_DIGI96_8_PRO 0x3fc2 -#define PCI_DEVICE_IDRME__DIGI96_8_PAD_OR_PST 0x3fc3 +#define PCI_DEVICE_ID_RME_DIGI96_8_PAD_OR_PST 0x3fc3#define PCI_DEVICE_ID_XILINX_HAMMERFALL 0x3fc4#define PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP 0x3fc5#define PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP_MADI 0x3fc6
sound/pci/rme32.c +22 -22
122 lines not on this page · raw message
sound/pci/rme96.c +30 -30
136 lines not on this page · raw message
At Tue, 13 Sep 2005 20:52:53 -0700,
Quoted 14 lines · Roland Dreier
While doing an allyesconfig build, I noticed that the commit
commit
8cdfd2519c6c9a1e6057dc5970b2542b35895738
Author: Takashi Iwai <[email protected]>
Date: Wed Sep 7 14:08:11 2005 +0200[ALSA] Remove superfluous PCI ID definitions
broke the RME32 and RME96 drivers, since the PCI IDs they use seem to have changed names. Here's a patch to fix this -- compile tested only, since I have no idea what the hardware even is.
Quoted 8 lines
Fix the build of the RME32 and RME96 drivers by having them use the
PCI_DEVICE_ID_RME_xxxnames defined in <linux/pci_ids.h> instead of thePCI_DEVICE_ID_xxxnames that they used to define themselves.Also fix the typo in the id
PCI_DEVICE_IDRME__DIGI96_8_PAD_OR_PSTso the name isPCI_DEVICE_ID_RME_DIGI96_8_PAD_OR_PST.Signed-off-by Roland Dreier <[email protected]>
Thanks. It seems that I submitted an older file.
It was intentional to use PCI_DEVICE_ID_DIGI96* to keep the patch smaller. But, PCI_DEVICE_ID_RME_* looks more consistent.
Please apply it.
Takashi