ACPI / video: Add systems that should favour native backlight interface

PATCH In review Aaron Lu 5 participants 8 messages Feb 18, 2014 – Feb 19, 2014

Subsystems (2)

ACPI x86 platform drivers

lore

Share & tools

lore

Aaron Lu

author

2014-02-18 05:54 UTC #0 lore raw

PATCH v4 1/1 ACPI / video: Add systems that should favour native backlight interface

Some system's ACPI video backlight control interface is broken and the native backlight control interface should be used by default. This patch sets the use_native_backlight parameter to true for those systems so that video backlight control interface will not be created. For detailed models that are added here, reference the following list.

Note that the user specified kernel cmdline option will always have the highest priority, i.e. if use_native_backlight=0 is specified and the system is in the DMI table, the video module will not skip registering backlight interface for it.

Thinkpad T430s:

Reported-by Theodore Tso <[email protected]>

Reported-and-tested-by Peter Weber <[email protected]>

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231
Thinkpad X230:

Reported-and-tested-by Igor Gnatenko <[email protected]>

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231
ThinkPad X1 Carbon:

Reported-and-tested-by Igor Gnatenko <[email protected]>

Lenovo Yoga 13:

Reported-by Lennart Poettering <[email protected]>

Reported-and-tested-by Kevin Smith <[email protected]>

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=63811
Dell Inspiron 7520:

Reported-by Rinat Ibragimov <[email protected]>

Acer Aspire 5733Z:

Reported-by <[email protected]>

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=62941
Acer Aspire V5-431:

Reported-by Thomas Christensen <[email protected]>

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=68751
HP ProBook 4340s:

Reported-and-tested-by Vladimir Sherenkov <[email protected]>

Reference: http://redmine.russianfedora.pro/issues/1258
HP EliteBook/ProBook 2013 models, ZBook and some others:

Provided-by Takashi Iwai <[email protected]>

Signed-off-by Aaron Lu <[email protected]>

---
 drivers/acpi/blacklist.c    |   8 ---
 drivers/acpi/video.c        | 139 ++++++++++++++++++++++++++++++++++++++++++--
 drivers/acpi/video_detect.c |  16 -----
 3 files changed, 134 insertions(+), 29 deletions(-)

drivers/acpi/blacklist.c +0 -8

index 10e4964d051a..e8e4c3dfaff7 100644
@@ -260,14 +260,6 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 	},
 	{
 	.callback = dmi_disable_osi_win8,
-	.ident = "Dell Inspiron 15R SE",
-	.matches = {
-		     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-		     DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7520"),
-		},
-	},
-	{
-	.callback = dmi_disable_osi_win8,
 	.ident = "ThinkPad Edge E530",
 	.matches = {
 		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

drivers/acpi/video.c +134 -5

166 lines not on this page · raw message

drivers/acpi/video_detect.c +0 ~~-16~~

index a697b77b8865..19080c8e2f2a 100644
@@ -168,22 +168,6 @@ static struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
 		},
 	},
-	{
-	.callback = video_detect_force_vendor,
-	.ident = "HP EliteBook Revolve 810",
-	.matches = {
-		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
-		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook Revolve 810 G1"),
-		},
-	},
-	{
-	.callback = video_detect_force_vendor,
-	.ident = "Lenovo Yoga 13",
-	.matches = {
-		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-		DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo IdeaPad Yoga 13"),
-		},
-	},
 	{ },
 };

Signature · 1 line

1.8.5.3

Mika Westerberg

2014-02-18 10:27 UTC #1 lore raw

drivers/acpi/video.c static struct dmi_system_id video_dmi_table[] __initdata = { · line 541

Quoted 9 lines · Aaron Lu

drivers/acpi/video.c +9 -0

+	{
+	.callback = video_set_use_native_backlight,
+	.ident = "HP EliteBook 2013 models",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
+		DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
+		},
+	},

I see my device is listed here but the above doesn't really use native backlight because it is still in acpi_osi blacklist. Tried this and I can see both acpi_video0 and intel_backlight listed under /sys/class/backlight. Was this the intention?

Takashi Iwai

2014-02-18 13:31 UTC #2 lore raw

At Tue, 18 Feb 2014 12:34:42 +0200,

Quoted 16 lines · Mika Westerberg

drivers/acpi/video.c static struct dmi_system_id video_dmi_table[] __initdata = { · line 541
Quoted 9 lines · Aaron Lu
drivers/acpi/video.c +9 -0
+	{
+	.callback = video_set_use_native_backlight,
+	.ident = "HP EliteBook 2013 models",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
+		DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
+		},
+	},
I see my device is listed here but the above doesn't really use native backlight because it is still in acpi_osi blacklist. Tried this and I can see both acpi_video0 and intel_backlight listed under /sys/class/backlight. Was this the intention?

The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I mentioned earlier. But the revert can be done individually after merging this patch. Rafael, could you care?

Takashi

Rafael J. Wysocki

2014-02-18 15:07 UTC #3 lore raw

Quoted 19 lines · Takashi Iwai

At Tue, 18 Feb 2014 12:34:42 +0200,
Quoted 16 lines · Mika Westerberg
drivers/acpi/video.c static struct dmi_system_id video_dmi_table[] __initdata = { · line 541
Quoted 9 lines · Aaron Lu
drivers/acpi/video.c +9 -0
+	{
+	.callback = video_set_use_native_backlight,
+	.ident = "HP EliteBook 2013 models",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
+		DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
+		},
+	},
I see my device is listed here but the above doesn't really use native backlight because it is still in acpi_osi blacklist. Tried this and I can see both acpi_video0 and intel_backlight listed under /sys/class/backlight. Was this the intention?

Quoted 3 lines

The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I mentioned earlier. But the revert can be done individually after merging this patch. Rafael, could you care?

Done. Please check the result in linux-pm.git/linux-next.

Thanks,
Rafael

Mika Westerberg

Tested-by

2014-02-18 15:39 UTC #4 lore raw

Quoted 20 lines · Rafael J. Wysocki

Quoted 19 lines · Takashi Iwai
At Tue, 18 Feb 2014 12:34:42 +0200,
Quoted 16 lines · Mika Westerberg
drivers/acpi/video.c static struct dmi_system_id video_dmi_table[] __initdata = { · line 541
Quoted 9 lines · Aaron Lu
drivers/acpi/video.c +9 -0
+	{
+	.callback = video_set_use_native_backlight,
+	.ident = "HP EliteBook 2013 models",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
+		DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
+		},
+	},
I see my device is listed here but the above doesn't really use native backlight because it is still in acpi_osi blacklist. Tried this and I can see both acpi_video0 and intel_backlight listed under /sys/class/backlight. Was this the intention?

Quoted 5 lines

Quoted 3 lines
The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I mentioned earlier. But the revert can be done individually after merging this patch. Rafael, could you care?
Done. Please check the result in linux-pm.git/linux-next.

With your revert and this patch from Aaron, backlight on my HP EliteBook Revolve G1 works fine, thanks!

Tested-by Mika Westerberg <[email protected]>

Igor Gnatenko

2014-02-18 19:28 UTC #6 lore raw

In reply to Rafael J. Wysocki

Quoted 20 lines · Rafael J. Wysocki

Quoted 19 lines · Takashi Iwai
At Tue, 18 Feb 2014 12:34:42 +0200,
Quoted 16 lines · Mika Westerberg
drivers/acpi/video.c static struct dmi_system_id video_dmi_table[] __initdata = { · line 541
Quoted 9 lines · Aaron Lu
drivers/acpi/video.c +9 -0
+	{
+	.callback = video_set_use_native_backlight,
+	.ident = "HP EliteBook 2013 models",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
+		DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
+		},
+	},
I see my device is listed here but the above doesn't really use native backlight because it is still in acpi_osi blacklist. Tried this and I can see both acpi_video0 and intel_backlight listed under /sys/class/backlight. Was this the intention?

Quoted 5 lines

Quoted 3 lines
The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I mentioned earlier. But the revert can be done individually after merging this patch. Rafael, could you care?
Done. Please check the result in linux-pm.git/linux-next.

Is it will merge to 3.14 ?

P.S. why you don't using rafael@ mail ? *joke*

Quoted 4 lines

Thanks,
Rafael

Signature · 1 line

-Igor Gnatenko

Rafael J. Wysocki

2014-02-18 22:20 UTC #7 lore raw

Quoted 21 lines · Igor Gnatenko

Quoted 20 lines · Rafael J. Wysocki
Quoted 19 lines · Takashi Iwai
At Tue, 18 Feb 2014 12:34:42 +0200,
Quoted 16 lines · Mika Westerberg
drivers/acpi/video.c static struct dmi_system_id video_dmi_table[] __initdata = { · line 541
Quoted 9 lines · Aaron Lu
drivers/acpi/video.c +9 -0
+	{
+	.callback = video_set_use_native_backlight,
+	.ident = "HP EliteBook 2013 models",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
+		DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
+		},
+	},
I see my device is listed here but the above doesn't really use native backlight because it is still in acpi_osi blacklist. Tried this and I can see both acpi_video0 and intel_backlight listed under /sys/class/backlight. Was this the intention?

Quoted 6 lines

Quoted 5 lines
Quoted 3 lines
The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I mentioned earlier. But the revert can be done individually after merging this patch. Rafael, could you care?
Done. Please check the result in linux-pm.git/linux-next.
Is it will merge to 3.14 ?

That's the plan.

Quoted 1 line

P.S. why you don't using rafael@ mail ? *joke*

Because it is hooked up to gmail. And I actually do use it sometimes.

Thanks,
Rafael

Aaron Lu

author

2014-02-19 02:57 UTC #5 lore raw

In reply to Mika Westerberg

Quoted 25 lines · Mika Westerberg

Quoted 24 lines · Rafael J. Wysocki
Quoted 22 lines · Takashi Iwai
At Tue, 18 Feb 2014 12:34:42 +0200,
Quoted 16 lines · Mika Westerberg
drivers/acpi/video.c static struct dmi_system_id video_dmi_table[] __initdata = { · line 541
Quoted 9 lines · Aaron Lu
drivers/acpi/video.c +9 -0
+	{
+	.callback = video_set_use_native_backlight,
+	.ident = "HP EliteBook 2013 models",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
+		DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
+		},
+	},
I see my device is listed here but the above doesn't really use native backlight because it is still in acpi_osi blacklist. Tried this and I can see both acpi_video0 and intel_backlight listed under /sys/class/backlight. Was this the intention?
The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I mentioned earlier. But the revert can be done individually after merging this patch. Rafael, could you care?

Quoted 6 lines

Quoted 1 line
Done. Please check the result in linux-pm.git/linux-next.
With your revert and this patch from Aaron, backlight on my HP EliteBook Revolve G1 works fine, thanks!
Tested-by Mika Westerberg <[email protected]>

Thanks for the test Mika and sorry for all the confusions caused.

-Aaron