Skip to contentSkip to conversation

mtip32xx: Reduce the number of unaligned writes to 2

PATCH In review Asai Thambi S P 2 participants 2 messages Feb 18, 2014 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtip32xx: Reduce the number of unaligned writes to 2

Hi Jens,

Please include this for 3.14. It is a trivial change, hope it should be ok.

--
Regards,
Asai

After several experiments, deduced the the optimal number of unaligned writes to be 2. Changing the value accordingly.

---
 drivers/block/mtip32xx/mtip32xx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/drivers/block/mtip32xx/mtip32xx.h
index b52e9a6..54174cb 100644

drivers/block/mtip32xx/mtip32xx.h +1 -1
@@ -53,7 +53,7 @@
 #define MTIP_FTL_REBUILD_TIMEOUT_MS    2400000
 
 /* unaligned IO handling */
-#define MTIP_MAX_UNALIGNED_SLOTS       8
+#define MTIP_MAX_UNALIGNED_SLOTS       2
 
 /* Macro to extract the tag bit number from a tag value. */
 #define MTIP_TAG_BIT(tag)      (tag & 0x1F)

--
1.7.1

maintainer
#1 lore raw
Quoted 3 lines · Asai Thambi S P

Hi Jens,

Please include this for 3.14. It is a trivial change, hope it should be ok.

I have applied it. However, your mailer seems to be changing tabs to spaces, so it had to be hand applied. Not a big deal for this patch, but worth checking up on for bigger patches.

Signature · 1 line
Jens Axboe