xfs_metadump: include F in getopts string
PATCH 1/1 xfs_metadump: include F in getopts string
I added an F case, but didn't add it to the bash
getopts string last go-round.
/usr/sbin/xfs_metadump: illegal option -- F
I sure thought I tested this, I'm not sure how it got lost.
---
db/xfs_metadump.sh +1 -1
@@ -7,7 +7,7 @@ OPTS=" " DBOPTS=" " USAGE="Usage: xfs_metadump [-efFogwV] [-m max_extents] [-l logdev] source target" -while getopts "efgl:m:owV" c +while getopts "efgl:m:owFV" c do case $c in e) OPTS=$OPTS"-e ";;
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 16 lines · Eric Sandeen
I added an F case, but didn't add it to the bash
getopts string last go-round.
/usr/sbin/xfs_metadump: illegal option -- FI sure thought I tested this, I'm not sure how it got lost.
Reported-by Boris Ranto<[email protected]>Signed-off-by Eric Sandeen<[email protected]>---
db/xfs_metadump.sh +0
-0
db/xfs_metadump.sh OPTS=" " · line 13
Quoted 8 lines
db/xfs_metadump.sh +1
-1@@ -7,7 +7,7 @@ OPTS=" " DBOPTS=" " USAGE="Usage: xfs_metadump [-efFogwV] [-m max_extents] [-l logdev] source target" -while getopts "efgl:m:owV" c +while getopts "efgl:m:owFV" c do case $c in e) OPTS=$OPTS"-e ";;
Looks good.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Eric Sandeen
I added an F case, but didn't add it to the bash
getopts string last go-round.
/usr/sbin/xfs_metadump: illegal option -- FI sure thought I tested this, I'm not sure how it got lost.
Well, better write a test for xfstests so that we can test it as part of the regression test run.
Otherwise:
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs