network tests: help script to run commands on remote host

There are some network tests which need to run various commands on the remote host. So is it a good idea to add a help script which does that according to chosen network protocol: rsh or ssh?

If yes, we can have a script like tst_rhost_run (or tst_run_rcmd...) in the ltp/tools, or somewhere else.

I did something similar in the submitted tcp_fastopen test, so the script could be as follows:

if [ "$use_ssh" -eq 1 ]; then

	ssh -n -f $user_name@$RHOST "sh -c 'nohup $rcmd &'" > /dev/null 2>&1
else
	rsh -n -l $user_name $RHOST "sh -c 'nohup $rcmd &'" > /dev/null 2>&1

fi

if [ $? -ne 0 ]; then
tst_brkm TBROK NULL "No route to host $RHOST" exit 2
fi

Quoted 22 lines

Quoted 14 lines

There are some network tests which need to run various commands on the remote host. So is it a good idea to add a help script which does that according to chosen network protocol: rsh or ssh?

If yes, we can have a script like tst_rhost_run (or tst_run_rcmd...) in the ltp/tools, or somewhere else.

I did something similar in the submitted tcp_fastopen test, so the script could be as follows:

if [ "$use_ssh" -eq 1 ]; then

	ssh -n -f $user_name@$RHOST "sh -c 'nohup $rcmd &'" > /dev/null 2>&1
else
	rsh -n -l $user_name $RHOST "sh -c 'nohup $rcmd &'" > /dev/null 2>&1

Quoted 6 lines

fi

if [ $? -ne 0 ]; then
tst_brkm TBROK NULL "No route to host $RHOST" exit 2
fi

Sounds good to me. The location for the file could be testcases/lib/.

Quoted 9 lines

One problem with the code above is that the error message can be misleading, there is much more that could go wrong. One that comes to my mind is when LTP is not installed on the remote machine.

And ideally we should use the new test.sh library. I would go for exporting an TST_LIB_LOADED=1 variable in the test.sh and checking in all sublibs that the variable exists to force the test to source the test.sh first.

OK, there is a question regarding different options for the command, e.g. we can have:

(quoted diff) +0 -3

-b  run in background
-s  safe option, if something goes wrong, will exit with TBROK
-c  command

Is this acceptable or I missed something?