rsi: MAC80211 callbacks to driver
PATCH v3 5/10 rsi: MAC80211 callbacks to driver
From: Fariya Fatima
This patch has MAC80211 callbacks to driver.
---
rsi_91x_mac80211.c | 744 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 744 insertions
drivers/net/wireless/rsi/rsi_91x_mac80211.c +744 -0
@@ -0,0 +1,744 @@ +/** +* Copyright (c) 2014 Redpine Signals Inc. +* +* Permission to use, copy, modify, and/or distribute this software for any +* purpose with or without fee is hereby granted, provided that the above +* copyright notice and this permission notice appear in all copies. +* +* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +*/ + +#include <linux/etherdevice.h> +#ifdef CONFIG_RSI_DEBUGFS +#include "rsi_debugfs.h" +#endif +#include "rsi_mgmt.h" +#include "rsi_common.h" + +static const struct ieee80211_channel rsi_2ghz_channels[] = { + { .band =IEEE80211_BAND_2GHZ , .center_freq =2412 , + .hw_value =1 },/* Channel 1 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2417 , + .hw_value =2 },/* Channel 2 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2422 , + .hw_value =3 },/* Channel 3 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2427 , + .hw_value =4 },/* Channel 4 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2432 , + .hw_value =5 },/* Channel 5 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2437 , + .hw_value =6 },/* Channel 6 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2442 , + .hw_value =7 },/* Channel 7 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2447 , + .hw_value =8 },/* Channel 8 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2452 , + .hw_value =9 },/* Channel 9 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2457 , + .hw_value =10 },/* Channel 10 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2462 , + .hw_value =11 },/* Channel 11 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2467 , + .hw_value =12 },/* Channel 12 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2472 , + .hw_value =13 },/* Channel 13 */ + { .band =IEEE80211_BAND_2GHZ , .center_freq =2484 , + .hw_value =14 },/* Channel 14 */ +}; + +static const struct ieee80211_channel rsi_5ghz_channels[] = { + { .band =IEEE80211_BAND_5GHZ , .center_freq =5180 , + .hw_value =36 , },/* Channel 36 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5200 , + .hw_value =40 , },/* Channel 40 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5220 , + .hw_value =44 , },/* Channel 44 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5240 , + .hw_value =48 , },/* Channel 48 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5260 , + .hw_value =52 , },/* Channel 52 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5280 , + .hw_value =56 , },/* Channel 56 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5300 , + .hw_value =60 , },/* Channel 60 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5320 , + .hw_value =64 , },/* Channel 64 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5500 , + .hw_value =100 , },/* Channel 100 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5520 , + .hw_value =104 , },/* Channel 104 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5540 , + .hw_value =108 , },/* Channel 108 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5560 , + .hw_value =112 , },/* Channel 112 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5580 , + .hw_value =116 , },/* Channel 116 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5600 , + .hw_value =120 , },/* Channel 120 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5620 , + .hw_value =124 , },/* Channel 124 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5640 , + .hw_value =128 , },/* Channel 128 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5660 , + .hw_value =132 , },/* Channel 132 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5680 , + .hw_value =136 , },/* Channel 136 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5700 , + .hw_value =140 , },/* Channel 140 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5745 , + .hw_value =149 , },/* Channel 149 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5765 , + .hw_value =153 , },/* Channel 153 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5785 , + .hw_value =157 , },/* Channel 157 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5805 , + .hw_value =161 , },/* Channel 161 */ + { .band =IEEE80211_BAND_5GHZ , .center_freq =5825 , + .hw_value =165 , },/* Channel 165 */ +}; + +struct ieee80211_rate rsi_rates[12 ] = { + { .bitrate =STD_RATE_01 *5 , .hw_value =RSI_RATE_1 }, + { .bitrate =STD_RATE_02 *5 , .hw_value =RSI_RATE_2 }, + { .bitrate =STD_RATE_5_5 *5 , .hw_value =RSI_RATE_5_5 }, + { .bitrate =STD_RATE_11 *5 , .hw_value =RSI_RATE_11 }, + { .bitrate =STD_RATE_06 *5 , .hw_value =RSI_RATE_6 }, + { .bitrate =STD_RATE_09 *5 , .hw_value =RSI_RATE_9 }, + { .bitrate =STD_RATE_12 *5 , .hw_value =RSI_RATE_12 }, + { .bitrate =STD_RATE_18 *5 , .hw_value =RSI_RATE_18 }, + { .bitrate =STD_RATE_24 *5 , .hw_value =RSI_RATE_24 }, + { .bitrate =STD_RATE_36 *5 , .hw_value =RSI_RATE_36 }, + { .bitrate =STD_RATE_48 *5 , .hw_value =RSI_RATE_48 }, + { .bitrate =STD_RATE_54 *5 , .hw_value =RSI_RATE_54 }, +}; + +const u16 rsi_mcsrates[8 ] = { +RSI_RATE_MCS0 ,RSI_RATE_MCS1 ,RSI_RATE_MCS2 ,RSI_RATE_MCS3 , +RSI_RATE_MCS4 ,RSI_RATE_MCS5 ,RSI_RATE_MCS6 ,RSI_RATE_MCS7 +}; + +/** +* This function determines if the ptk cipher is WEP or not. +* +* @param common Pointer to the driver private structure. +* @return If cipher type is WEP, a value of 1 is returned, else 0. +*/ + +bool rsi_is_cipher_wep (struct rsi_common *common) +{ +if (((common->secinfo.gtk_cipher ==WLAN_CIPHER_SUITE_WEP104 ) || + (common->secinfo.gtk_cipher ==WLAN_CIPHER_SUITE_WEP40 )) && + (!common->secinfo.ptk_cipher)) +return true; +else +return false; +} + +/** +* This function registers the channels and rates. +* +* @param adapter Pointer to the adapter structure. +* @param band Operating band to be set. +* @return None. +*/ +static void rsi_register_rates_channels (struct rsi_hw *adapter,int band) +{ +struct ieee80211_supported_band *sbands = &adapter->sbands[band]; +void *channels =NULL ; + +if (band ==IEEE80211_BAND_2GHZ ) { + channels =kmalloc (sizeof (rsi_2ghz_channels),GFP_KERNEL ); +memcpy (channels, + rsi_2ghz_channels, +sizeof (rsi_2ghz_channels)); + sbands->band =IEEE80211_BAND_2GHZ ; + sbands->n_channels =ARRAY_SIZE (rsi_2ghz_channels); + sbands->bitrates = rsi_rates; + sbands->n_bitrates =ARRAY_SIZE (rsi_rates); + }else { + channels =kmalloc (sizeof (rsi_5ghz_channels),GFP_KERNEL ); +memcpy (channels, + rsi_5ghz_channels, +sizeof (rsi_5ghz_channels)); + sbands->band =IEEE80211_BAND_5GHZ ; + sbands->n_channels =ARRAY_SIZE (rsi_5ghz_channels); + sbands->bitrates = &rsi_rates[4 ]; + sbands->n_bitrates =ARRAY_SIZE (rsi_rates) -4 ; + } + + sbands->channels = channels; + +memset (&sbands->ht_cap,0 ,sizeof (struct ieee80211_sta_ht_cap )); + sbands->ht_cap.ht_supported = true; + sbands->ht_cap.cap = (IEEE80211_HT_CAP_SUP_WIDTH_20_40 | +IEEE80211_HT_CAP_SGI_20 | +IEEE80211_HT_CAP_SGI_40 ); + sbands->ht_cap.ampdu_factor =IEEE80211_HT_MAX_AMPDU_8K ; + sbands->ht_cap.ampdu_density =IEEE80211_HT_MPDU_DENSITY_NONE ; + sbands->ht_cap.mcs.rx_mask[0 ] =0xff ; + sbands->ht_cap.mcs.tx_params =IEEE80211_HT_MCS_TX_DEFINED ; +/* sbands->ht_cap.mcs.rx_highest = 0x82; */ +} + +/** +* This function is used to de-initialize Mac80211 stack. +* +* @param adapter Pointer to the adapter structure. +* @return None. +*/ +void rsi_mac80211_detach (struct rsi_hw *adapter) +{ +struct ieee80211_hw *hw = adapter->hw; + +if (hw) { +ieee80211_stop_queues (hw); +ieee80211_unregister_hw (hw); +ieee80211_free_hw (hw); + } + +#ifdef CONFIG_RSI_DEBUGFS +rsi_remove_dbgfs (adapter); +#endif +return ; +} +EXPORT_SYMBOL_GPL (rsi_mac80211_detach); + +/** +* This function indicates the transmit status. +* +* @param adapter Pointer to the adapter structure. +* @param skb Pointer to the socket buffer structure. +* @param status Status +* @return None. +*/ +void rsi_indicate_tx_status (struct rsi_hw *adapter, +struct sk_buff *skb, +int status) +{ +struct ieee80211_tx_info *info =IEEE80211_SKB_CB (skb); + +memset (info->driver_data,0 ,IEEE80211_TX_INFO_DRIVER_DATA_SIZE ); + +if (!status) + info->flags |=IEEE80211_TX_STAT_ACK ; + +ieee80211_tx_status_irqsafe (adapter->hw, skb); +} + +/** +* This is the handler that 802.11 module calls for each transmitted frame. +* skb contains the buffer starting from the IEEE 802.11 header. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param control Pointer to the ieee80211_tx_control structure +* @param skb Pointer to the socket buffer structure. +* @return None +*/ +static void rsi_mac80211_tx (struct ieee80211_hw *hw, +struct ieee80211_tx_control *control, +struct sk_buff *skb) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; + +rsi_core_xmit (common, skb); + +return ; +} + +/** +* This is first handler that 802.11 module calls, since the driver init +* is complete by then, just returns success. +* +* @param hw Pointer to the ieee80211_hw structure. +* @return 0 as success. +*/ +static int rsi_mac80211_start (struct ieee80211_hw *hw) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; + +mutex_lock (&common->mutex); + common->iface_down = false; +mutex_unlock (&common->mutex); + +return 0 ; +} + +/** +* This is the last handler that 802.11 module calls. +* +* @param hw Pointer to the ieee80211_hw structure. +* @return None. +*/ +static void rsi_mac80211_stop (struct ieee80211_hw *hw) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; + +mutex_lock (&common->mutex); + common->iface_down = true; +mutex_unlock (&common->mutex); + +return ; +} + +/** +* This function is called when a netdevice attached to the hardware is enabled. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param vif Pointer to the ieee80211_vif structure. +* @return ret: 0 on success, negative error code on failure. +*/ +static int rsi_mac80211_add_interface (struct ieee80211_hw *hw, +struct ieee80211_vif *vif) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; +int ret = -EOPNOTSUPP ; + +mutex_lock (&common->mutex); +switch (vif->type) { +case NL80211_IFTYPE_STATION : +if (!adapter->sc_nvifs) { + ++adapter->sc_nvifs; + adapter->vifs[0 ] = vif; + ret =rsi_set_vap_capabilities (common,STA_OPMODE ); + } +break ; +default : +rsi_dbg (ERR_ZONE , +"%s: Interface type %d not supported\n" , __func__, + vif->type); + } +mutex_unlock (&common->mutex); + +return ret; +} + +/** +* This function notifies driver that an interface is going down. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param vif Pointer to the ieee80211_vif structure. +* @return None. +*/ +static void rsi_mac80211_remove_interface (struct ieee80211_hw *hw, +struct ieee80211_vif *vif) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; + +mutex_lock (&common->mutex); +if (vif->type ==NL80211_IFTYPE_STATION ) + adapter->sc_nvifs--; + +if (!memcmp (adapter->vifs[0 ], vif,sizeof (struct ieee80211_vif ))) + adapter->vifs[0 ] =NULL ; +mutex_unlock (&common->mutex); + +return ; +} + +/** +* This function is a handler for configuration requests. The stack calls +* this function to change hardware configuration, e.g., channel. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param changed Changed flags set. +* @return 0 on success, negative error code on failure. +*/ +static int rsi_mac80211_config (struct ieee80211_hw *hw, +u32 changed) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; +int status = -EOPNOTSUPP ; + +mutex_lock (&common->mutex); +if (changed &IEEE80211_CONF_CHANGE_CHANNEL ) { +struct ieee80211_channel *curchan = hw->conf.chandef.chan; +u16 channel = curchan->hw_value; + +rsi_dbg (INFO_ZONE , +"%s: Set channel: %d MHz type: %d channel_no %d\n" , + __func__, curchan->center_freq, + curchan->flags, channel); + common->band = curchan->band; + status =rsi_set_channel (adapter->priv, channel); + } +mutex_unlock (&common->mutex); + +return status; +} + +/** +* This function is used to get the current connected channel number. +* +* @param adapter Pointer to the struct rsi_hw +* @return Current connected AP's channel number is returned. +*/ +u16 rsi_get_connected_channel (struct rsi_hw *adapter) +{ +struct ieee80211_vif *vif = adapter->vifs[0 ]; +if (vif) { +struct ieee80211_bss_conf *bss = &vif->bss_conf; +struct ieee80211_channel *channel = bss->chandef.chan; +return channel->hw_value; + } + +return 0 ; +} + +/** +* This function is a handler for configuration requests related to BSS +* parameters that may vary during BSS's lifespan. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param vif Pointer to the ieee80211_vif structure. +* @param bss_conf Pointer to the ieee80211_bss_conf structure. +* @param changed Changed flags set. +* @return None. +*/ +static void rsi_mac80211_bss_info_changed (struct ieee80211_hw *hw, +struct ieee80211_vif *vif, +struct ieee80211_bss_conf *bss_conf, +u32 changed) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; + +mutex_lock (&common->mutex); +if (changed &BSS_CHANGED_ASSOC ) { +rsi_dbg (INFO_ZONE ,"%s: Changed Association status: %d\n" , + __func__, bss_conf->assoc); +rsi_inform_bss_status (common, + bss_conf->assoc, + bss_conf->bssid, + bss_conf->qos, + bss_conf->aid); + } +mutex_unlock (&common->mutex); + +return ; +} + +/** +* This function configures the device's RX filter. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param changed Changed flags set. +* @param total_flags Total initial flags set. +* @param multicast Multicast. +* @return None. +*/ +static void rsi_mac80211_conf_filter (struct ieee80211_hw *hw, +u32 changed_flags, +u32 *total_flags, +u64 multicast) +{ + *total_flags &=FIF_FCSFAIL ; + changed_flags &=FIF_FCSFAIL ; + +return ; +} + +/** +* This function configures TX queue parameters (EDCF (aifs, cw_min, cw_max), +* bursting) for a hardware TX queue. +* +* @param hw Pointer to the ieee80211_hw structure +* @param vif Pointer to the ieee80211_vif structure. +* @param queue Queue number. +* @param params Pointer to ieee80211_tx_queue_params structure. +* @return 0 on success, negative error code on failure. +*/ +static int rsi_mac80211_conf_tx (struct ieee80211_hw *hw, +struct ieee80211_vif *vif,u16 queue, +const struct ieee80211_tx_queue_params *params) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; +u8 idx =0 ; + +if (queue >=IEEE80211_NUM_ACS ) +return 0 ; + +rsi_dbg (INFO_ZONE , +"%s: Conf queue %d, aifs: %d, cwmin: %d cwmax: %d, txop: %d\n" , + __func__, queue, params->aifs, + params->cw_min, params->cw_max, params->txop); + +mutex_lock (&common->mutex); +/* Map into the way the f/w expects */ +switch (queue) { +case IEEE80211_AC_VO : + idx =VO_Q ; +break ; +case IEEE80211_AC_VI : + idx =VI_Q ; +break ; +case IEEE80211_AC_BE : + idx =BE_Q ; +break ; +case IEEE80211_AC_BK : + idx =BK_Q ; +break ; +default : + idx =BE_Q ; +break ; + } + +memcpy (&common->edca_params[idx], + params, +sizeof (struct ieee80211_tx_queue_params )); +mutex_unlock (&common->mutex); + +return 0 ; +} + +/** +* This function loads the keys into the firmware. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param vif Pointer to the ieee80211_vif structure. +* @param key Pointer to the ieee80211_key_conf structure. +* @return status: 0 on success, -1 on failure. +*/ +static int rsi_hal_key_config (struct ieee80211_hw *hw, +struct ieee80211_vif *vif, +struct ieee80211_key_conf *key) +{ +struct rsi_hw *adapter = hw->priv; +int status; +u8 key_type; + +if (key->flags &IEEE80211_KEY_FLAG_PAIRWISE ) + key_type =RSI_PAIRWISE_KEY ; +else + key_type =RSI_GROUP_KEY ; + +rsi_dbg (ERR_ZONE ,"%s: Cipher 0x%x key_type: %d key_len: %d\n" , + __func__, key->cipher, key_type, key->keylen); + +if ((key->cipher ==WLAN_CIPHER_SUITE_WEP104 ) || + (key->cipher ==WLAN_CIPHER_SUITE_WEP40 )) { + status =rsi_hal_load_key (adapter->priv, + key->key, + key->keylen, +RSI_PAIRWISE_KEY , + key->keyidx, + key->cipher); + } +return rsi_hal_load_key (adapter->priv, + key->key, + key->keylen, + key_type, + key->keyidx, + key->cipher); +} + +/** +* This function sets type of key to be loaded. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param cmd enum set_key_cmd. +* @param vif Pointer to the ieee80211_vif structure. +* @param sta Pointer to the ieee80211_sta structure. +* @param key Pointer to the ieee80211_key_conf structure. +* @return status: 0 on success, negative error code on failure. +*/ +static int rsi_mac80211_set_key (struct ieee80211_hw *hw, +enum set_key_cmd cmd, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta, +struct ieee80211_key_conf *key) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; +struct security_info *secinfo = &common->secinfo; +int status =0 ; + +mutex_lock (&common->mutex); +switch (cmd) { +case SET_KEY : + secinfo->security_enable = true; + status =rsi_hal_key_config (hw, vif, key); +if (status) { +mutex_unlock (&common->mutex); +return -EINVAL ; + } + +if (key->flags &IEEE80211_KEY_FLAG_PAIRWISE ) + secinfo->ptk_cipher = key->cipher; +else + secinfo->gtk_cipher = key->cipher; + + key->hw_key_idx = key->keyidx; + key->flags |=IEEE80211_KEY_FLAG_GENERATE_IV ; + +rsi_dbg (ERR_ZONE ,"%s: RSI set_key\n" , __func__); +break ; + +case DISABLE_KEY : + secinfo->security_enable = false; +rsi_dbg (ERR_ZONE ,"%s: RSI del key\n" , __func__); +memset (key,0 ,sizeof (struct ieee80211_key_conf )); + status =rsi_hal_key_config (hw, vif, key); +break ; + +default : + status = -EINVAL ; +break ; + } + +mutex_unlock (&common->mutex); +return status; +} + +/** +* This function selects the AMPDU action for the corresponding +* mlme_action flag and informs the f/w regarding this. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param vif Pointer to the ieee80211_vif structure. +* @param action ieee80211_ampdu_mlme_action enum. +* @param sta Pointer to the ieee80211_sta structure. +* @param tid Traffic identifier. +* @param ssn Pointer to ssn value. +* @param buf_size Buffer size (for kernel version > 2.6.38). +* @return status: 0 on success, negative error code on failure. +*/ +static int rsi_mac80211_ampdu_action (struct ieee80211_hw *hw, +struct ieee80211_vif *vif, +enum ieee80211_ampdu_mlme_action action, +struct ieee80211_sta *sta, +unsigned short tid, +unsigned short *ssn, +unsigned char buf_size) +{ +int status =0 ; +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; +u16 seq_no =0 ; +u8 ii =0 ; + +for (ii =0 ; ii <RSI_MAX_VIFS ; ii++) { +if (vif == adapter->vifs[ii]) +break ; + } + +mutex_lock (&common->mutex); +rsi_dbg (INFO_ZONE ,"%s: AMPDU action %d called\n" , __func__, action); +if (ssn !=NULL ) + seq_no = *ssn; + +switch (action) { +case IEEE80211_AMPDU_RX_START : + status =rsi_send_aggregation_params_frame (common, + tid, + seq_no, + buf_size, +STA_RX_ADDBA_DONE ); +break ; + +case IEEE80211_AMPDU_RX_STOP : + status =rsi_send_aggregation_params_frame (common, + tid, +0 , + buf_size, +STA_RX_DELBA ); +break ; + +case IEEE80211_AMPDU_TX_START : + common->vif_info[ii].seq_start = seq_no; +ieee80211_start_tx_ba_cb_irqsafe (vif, sta->addr, tid); +break ; + +case IEEE80211_AMPDU_TX_STOP_CONT : +case IEEE80211_AMPDU_TX_STOP_FLUSH : +case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT : + status =rsi_send_aggregation_params_frame (common, + tid, + seq_no, + buf_size, +STA_TX_DELBA ); +if (!status) +ieee80211_stop_tx_ba_cb_irqsafe (vif, sta->addr, tid); +break ; + +case IEEE80211_AMPDU_TX_OPERATIONAL : + status =rsi_send_aggregation_params_frame (common, + tid, + common->vif_info[ii] + .seq_start, + buf_size, +STA_TX_ADDBA_DONE ); +break ; + +default : +rsi_dbg (ERR_ZONE ,"%s: Uknown AMPDU action\n" , __func__); +break ; + } + +mutex_unlock (&common->mutex); +return status; +} + +/** +* This function sets the rts threshold value. +* +* @param hw Pointer to the ieee80211_hw structure. +* @param value Rts threshold value. +* @return 0 on success. +*/ +static int rsi_mac80211_set_rts_threshold (struct ieee80211_hw *hw, +u32 value) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; + +mutex_lock (&common->mutex); + common->rts_threshold = value; +mutex_unlock (&common->mutex); + +return 0 ; +} + +/** +* This function sets the bitrate_mask to be used. +* +* @param hw Pointer to the ieee80211_hw structure +* @param vif Pointer to the ieee80211_vif structure. +* @param mask Pointer to the cfg80211_bitrate_mask structure. +* @return 0 on success. +*/ +static int rsi_mac80211_set_rate_mask (struct ieee80211_hw *hw, +struct ieee80211_vif *vif, +const struct cfg80211_bitrate_mask *mask) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; + +mutex_lock (&common->mutex); + + common->fixedrate_mask[IEEE80211_BAND_2GHZ ] =0 ; + +if (mask->control[IEEE80211_BAND_2GHZ ].legacy ==0xfff ) { + common->fixedrate_mask[IEEE80211_BAND_2GHZ ] = + (mask->control[IEEE80211_BAND_2GHZ ].ht_mcs[0 ] <<12 ); + }else { + common->fixedrate_mask[IEEE80211_BAND_2GHZ ] = + mask->control[IEEE80211_BAND_2GHZ ].legacy; + } +mutex_unlock (&common->mutex); + +return 0 ; +} +
drivers/net/wireless/rsi/rsi_91x_mac80211.c line 207
Quoted 13 lines · Fariya Fatima
drivers/net/wireless/rsi/rsi_91x_mac80211.c +13
-0+void rsi_mac80211_detach (struct rsi_hw *adapter) +{ +struct ieee80211_hw *hw = adapter->hw; + +if (hw) { +ieee80211_stop_queues (hw); +ieee80211_unregister_hw (hw); +ieee80211_free_hw (hw); + } + +#ifdef CONFIG_RSI_DEBUGFS +rsi_remove_dbgfs (adapter); +#endif
Typically, you'd call this unconditionally and have the header file for it provide a static inline that does nothing with the ifdef, to reduce ifdefs in the code.
Review
Quoted 2 lines
(quoted diff) +2
-0+ return; +}
more naked returns
drivers/net/wireless/rsi/rsi_91x_mac80211.c line 447
Quoted 7 lines
drivers/net/wireless/rsi/rsi_91x_mac80211.c +7
-0+static void rsi_mac80211_conf_filter (struct ieee80211_hw *hw, +u32 changed_flags, +u32 *total_flags, +u64 multicast) +{ + *total_flags &=FIF_FCSFAIL ; + changed_flags &=FIF_FCSFAIL ;
That doesn't seem to be right?
Quoted 7 lines
drivers/net/wireless/rsi/rsi_91x_mac80211.c +7
-0+if ((key->cipher ==WLAN_CIPHER_SUITE_WEP104 ) || + (key->cipher ==WLAN_CIPHER_SUITE_WEP40 )) { + status = rsi_hal_load_key(adapter->priv, + key->key, + key->keylen, + RSI_PAIRWISE_KEY, + key->keyidx,
drivers/net/wireless/rsi/rsi_91x_mac80211.c line 544
Quoted 10 lines
drivers/net/wireless/rsi/rsi_91x_mac80211.c +8
-0+ key->cipher); + } +return rsi_hal_load_key (adapter->priv, + key->key, + key->keylen, + key_type, + key->keyidx, + key->cipher);
You really need to load WEP keys twice? And you want to ignore the status?
drivers/net/wireless/rsi/rsi_91x_mac80211.c line 566
Quoted 10 lines
drivers/net/wireless/rsi/rsi_91x_mac80211.c +10
-0+static int rsi_mac80211_set_key (struct ieee80211_hw *hw, +enum set_key_cmd cmd, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta, +struct ieee80211_key_conf *key) +{ +struct rsi_hw *adapter = hw->priv; +struct rsi_common *common = adapter->priv; +struct security_info *secinfo = &common->secinfo; +int status =0 ;
Like many other places, you shouldn't initialize variables if it's not needed - that way the compiler will warn you if you don't actually init them in some path. Particularly if you init them to "success" rather than an error.
Quoted 5 lines
+/**
+ * This function selects the AMPDU action for the corresponding
+ *mlme_actionflag and informs the f/w regarding this.
+ *
+ * @param hw Pointer to theieee80211_hwstructure.
None of this is valid kernel-doc by the way, so you should probably go through all of those things and fix them. See the kernel-doc nano howto and other files in Documentation/
Btw, git am also complains about whitespace damage in some patches.
johannes