host-fakeroot archive not sourced any more?

Buildroot Vincent Stehlé 3 participants 7 messages Mar 12, 2014 – Mar 13, 2014 Kbuild

Share & tools

Vincent Stehlé

author

2014-03-12 10:15 UTC #0 lore raw

Hi,

FYI it seems buildroot will not source host-fakeroot archive correctly any more when told to 'make source', with some configurations.

This behavior can be seen for example on recent commit 1ea6d850891bb4d936bcf1bddbf5432b819d5785, with the following commands:

   $ rm -fr ..config.tmp .config .config.old output dl/*fakeroot*
   $ make qemu_arm_vexpress_defconfig
   $ make source

In this case, fakeroot_1.18.2.orig.tar.bz2 is not fetched.

After bisect, it seems this behavior started with commit 'a248775
Makefile: add support for top-level parallel make'.

A quick fix for 1ea6d850891bb4d936bcf1bddbf5432b819d5785 is to revert, in that order:

cf53e15 Makefile: remove BASE_TARGETS variable fbb3b86 Makefile: ensure system is built ... d4c0c64 Makefile: fix target-finalize rule a248775 Makefile: add support for top-level parallel make

...and fakeroot archive is downloaded again.

Best regards,

Thomas De Schampheleire

2014-03-12 11:56 UTC #1 lore raw

Quoted 20 lines · Vincent Stehl?

Hi,
FYI it seems buildroot will not source host-fakeroot archive correctly any more when told to 'make source', with some configurations.
This behavior can be seen for example on recent commit 1ea6d850891bb4d936bcf1bddbf5432b819d5785, with the following commands:
  $ rm -fr ..config.tmp .config .config.old output dl/*fakeroot*
  $ make qemu_arm_vexpress_defconfig
  $ make source
In this case, fakeroot_1.18.2.orig.tar.bz2 is not fetched.
After bisect, it seems this behavior started with commit 'a248775 Makefile:
add support for top-level parallel make'.
A quick fix for 1ea6d850891bb4d936bcf1bddbf5432b819d5785 is to revert, in that order:

Quoted 7 lines

cf53e15 Makefile: remove BASE_TARGETS variable fbb3b86 Makefile: ensure system is built ... d4c0c64 Makefile: fix target-finalize rule a248775 Makefile: add support for top-level parallel make
...and fakeroot archive is downloaded again.

Vincent: thanks a lot for the report and the analysis!

Fabio: what is your suggestion here?

Thanks,
Thomas

Fabio Porcedda

2014-03-12 12:18 UTC #2 lore raw

Quoted 27 lines · Thomas De Schampheleire

Quoted 25 lines · Vincent Stehl?
Hi,
FYI it seems buildroot will not source host-fakeroot archive correctly any more when told to 'make source', with some configurations.
This behavior can be seen for example on recent commit 1ea6d850891bb4d936bcf1bddbf5432b819d5785, with the following commands:
  $ rm -fr ..config.tmp .config .config.old output dl/*fakeroot*
  $ make qemu_arm_vexpress_defconfig
  $ make source
In this case, fakeroot_1.18.2.orig.tar.bz2 is not fetched.
After bisect, it seems this behavior started with commit 'a248775 Makefile:
add support for top-level parallel make'.
A quick fix for 1ea6d850891bb4d936bcf1bddbf5432b819d5785 is to revert, in that order:
cf53e15 Makefile: remove BASE_TARGETS variable fbb3b86 Makefile: ensure system is built ... d4c0c64 Makefile: fix target-finalize rule a248775 Makefile: add support for top-level parallel make

Quoted 6 lines

Quoted 2 lines
...and fakeroot archive is downloaded again.
Vincent: thanks a lot for the report and the analysis!
Fabio: what is your suggestion here?

I will look at it, thanks for reporting it.

Regards

Signature · 1 line

Fabio Porcedda

Fabio Porcedda

2014-03-12 12:44 UTC #3 lore raw

Quoted 29 lines · Fabio Porcedda

Quoted 27 lines · Thomas De Schampheleire
Quoted 25 lines · Vincent Stehl?
Hi,
FYI it seems buildroot will not source host-fakeroot archive correctly any more when told to 'make source', with some configurations.
This behavior can be seen for example on recent commit 1ea6d850891bb4d936bcf1bddbf5432b819d5785, with the following commands:
  $ rm -fr ..config.tmp .config .config.old output dl/*fakeroot*
  $ make qemu_arm_vexpress_defconfig
  $ make source
In this case, fakeroot_1.18.2.orig.tar.bz2 is not fetched.
After bisect, it seems this behavior started with commit 'a248775 Makefile:
add support for top-level parallel make'.
A quick fix for 1ea6d850891bb4d936bcf1bddbf5432b819d5785 is to revert, in that order:
cf53e15 Makefile: remove BASE_TARGETS variable fbb3b86 Makefile: ensure system is built ... d4c0c64 Makefile: fix target-finalize rule a248775 Makefile: add support for top-level parallel make

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
...and fakeroot archive is downloaded again.
Vincent: thanks a lot for the report and the analysis!
Fabio: what is your suggestion here?
I will look at it, thanks for reporting it.

Can you try this patch?

Makefile +1 -1

index 481f779..e8e41a4 100644
@@ -418,7 +418,7 @@ TARGETS_DIRCLEAN := $(patsubst %,%-dirclean,$(TARGETS))
 # variable for each enabled target.
 # Notice: this only works for newstyle gentargets/autotargets packages
 TARGETS_HOST_DEPS = $(sort $(filter host-%,$(foreach dep,\
-               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
+               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)

$(TARGETS_ROOTFS))),\
                $($(dep)))))
 # Host packages can in turn have their own dependencies. Likewise find
 # all the package names listed in the HOST_<PKG>_DEPENDENCIES for each

Regards

Signature · 1 line

Fabio Porcedda

Vincent Stehlé

author

2014-03-12 14:11 UTC #4 lore raw

Quoted 3 lines · Fabio Porcedda

Makefile +1 -1

-               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
+               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)

$(TARGETS_ROOTFS))),\

Hi Fabio,

Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to use it instead of the reverts and see how it goes.

Best regards,

Fabio Porcedda

2014-03-12 14:25 UTC #5 lore raw

Quoted 11 lines · Vincent Stehl?

Quoted 4 lines · Fabio Porcedda
Makefile +1 -1
-               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
+               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)
$(TARGETS_ROOTFS))),\
Hi Fabio,
Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to use it instead of the reverts and see how it goes.

Great!
Thanks for testing it and sorry for the trouble.
I will send tomorrow the patch to the mailing list, maybe an improved version because i fear that i need to add TARGETS_ROOTFS in more places.

Best regards

Signature · 1 line

Fabio Porcedda

Fabio Porcedda

2014-03-13 16:38 UTC #6 lore raw

Quoted 11 lines · Fabio Porcedda

Quoted 9 lines · Vincent Stehl?
Quoted 4 lines · Fabio Porcedda
Makefile +1 -1
-               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
+               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)
$(TARGETS_ROOTFS))),\
Hi Fabio,

Quoted 8 lines

Quoted 2 lines
Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to use it instead of the reverts and see how it goes.
Great!
Thanks for testing it and sorry for the trouble.
I will send tomorrow the patch to the mailing list, maybe an improved version because i fear that i need to add TARGETS_ROOTFS in more places.

Patch sent:
http://patchwork.ozlabs.org/patch/330004/

Regards

Signature · 1 line

Fabio Porcedda