Proper way to do warm-reset from the driver?
On my firmware, I am often seeing 'tx not flushed' errors after bouncing 32 stations a few times.
It does not seem this error can ever be recovered because the reference counting is messed up.
I am planning to attempt a warm reset in this case, in hopes it will clear things up.
Is the preferred way to restart the nic just:
queue_work(ar->workqueue, &ar->restart_work);
?
Thanks,
Ben
Signature · 8 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 6 lines · Ben Greear
On my firmware, I am often seeing 'tx not flushed' errors after bouncing 32 stations a few times.
It does not seem this error can ever be recovered because the reference counting is messed up.
Quoted 6 lines
I am planning to attempt a warm reset in this case, in hopes it will clear things up.
Is the preferred way to restart the nic just:
queue_work(ar->workqueue, &ar->restart_work);
BTW, that call really should not be in ath10k_pci_hif_dump_area(). It's very misleading to have a function name which implies just printing stuff but actually also restarts firmware.
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 11 lines · Kalle Valo
Quoted 9 lines · Ben Greear
On my firmware, I am often seeing 'tx not flushed' errors after bouncing 32 stations a few times.
It does not seem this error can ever be recovered because the reference counting is messed up.
I am planning to attempt a warm reset in this case, in hopes it will clear things up.
Quoted 7 lines
Quoted 3 lines
Is the preferred way to restart the nic just:
queue_work(ar->workqueue, &ar->restart_work);BTW, that call really should not be in
ath10k_pci_hif_dump_area(). It's very misleading to have a function name which implies just printing stuff but actually also restarts firmware.
Yes, and it is not always called from that method anyway...bails out before resetting in some error cases.
My own tree has lots of patches to that method to dump more firmware memory areas and such, so it will not be so easy for me to produce a clean patch to fix this...
Thanks,
Ben
Quoted 1 line
Signature · 8 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k