Skip to contentSkip to conversation

ocfs2 : fix type conversion risk when get cluster attributes

PATCH New Joseph Qi 1 participant 1 message Mar 19, 2014 OCFS2

lore
Share & tools
lore

Joseph Qi

author
#0 lore raw

PATCH 1/1 ocfs2 : fix type conversion risk when get cluster attributes

In o2nm_cluster, cl_idle_timeout_ms, cl_keepalive_delay_ms, as well as cl_reconnect_delay_ms, are defined as type of unsigned int. So we should also use unsigned int in the helper functions.

---
 fs/ocfs2/cluster/tcp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/ocfs2/cluster/tcp.c +0 -0
index 2cd2406..b4ab371 100644
@@ -262,17 +262,17 @@ static void o2net_update_recv_stats(struct

o2net_sock_container *sc)

#endif /* CONFIG_OCFS2_FS_STATS */

-static inline int o2net_reconnect_delay(void) +static inline unsigned int o2net_reconnect_delay(void)
{
return o2nm_single_cluster->cl_reconnect_delay_ms;
}

-static inline int o2net_keepalive_delay(void) +static inline unsigned int o2net_keepalive_delay(void)
{
return o2nm_single_cluster->cl_keepalive_delay_ms;
}

-static inline int o2net_idle_timeout(void) +static inline unsigned int o2net_idle_timeout(void)
{
return o2nm_single_cluster->cl_idle_timeout_ms;
}
-- 1.8.4.3