Skip to contentSkip to conversation

xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

PATCH RESEND In review Denis Turischev 2 participants 4 messages Mar 21, 2014 – Apr 22, 2014

Subsystems (2)
USB USB xHCI driver
lore
Share & tools
lore

Denis Turischev

author
#0 lore raw

PATCH RESEND 1/1 xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for this, but not all. One example is Compulab's mini-desktop, the Intense-PC2.

The bug can be avoided if the USB ports are switched back to EHCI on shutdown.

Signed-off-by Denis Turischev <[email protected]>
---
 drivers/usb/host/xhci-pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/host/xhci-pci.c +2 -0
index 3c898c1..9233d12 100644
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		 */
 		if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
 			xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+		xhci->quirks |= XHCI_SPURIOUS_REBOOT;
 	}
 	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
 			pdev->device == PCI_DEVICE_ID_ASROCK_P67) {

-- 1.8.1.2

#1 lore raw
Quoted 8 lines · Denis Turischev

The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for this, but not all. One example is Compulab's mini-desktop, the Intense-PC2.

The bug can be avoided if the USB ports are switched back to EHCI on shutdown.

I'll queue this up and send it forward to Greg once 3.15-rc1 is out

-Mathias

author
#2 lore raw

Hi Mathias,

Just want to remind you about the patch, thanks.

Denis

Quoted 15 lines · Mathias Nyman
Quoted 8 lines · Denis Turischev

The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for this, but not all. One example is Compulab's mini-desktop, the Intense-PC2.

The bug can be avoided if the USB ports are switched back to EHCI on shutdown.

I'll queue this up and send it forward to Greg once 3.15-rc1 is out

-Mathias

#3 lore raw
Quoted 5 lines · Denis Turischev

Hi Mathias,

Just want to remind you about the patch, thanks.

Sent to Greg a minute ago, thanks

-Mathias