Skip to contentSkip to conversation

osm_sa_mcmember_record.c: Fix removing members from existing mc group due to invalid requests

PATCH New Hal Rosenstock 1 participant 1 message Mar 24, 2014 InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 osm_sa_mcmember_record.c: Fix removing members from existing mc group due to invalid requests

From: Daniel Klein <danielk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Date: Thu, 20 Mar 2014 10:26:51 +0200

Bug description:
If there is an existing well known group with only non-full members, and opensm receives an invalid join request. opensm removes all the member of the groups.

Signed-off-by Daniel Klein <danielk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 opensm/osm_sa_mcmember_record.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
opensm/osm_sa_mcmember_record.c +4 -2
index 96bddb7..85e7681 100644
@@ -1177,7 +1177,8 @@ static void mcmr_rcv_join_mgrp(IN osm_sa_t * sa, IN osm_madw_t * p_madw)
 	    || !(join_state != 0)) {
 		char gid_str[INET6_ADDRSTRLEN];
 		/* since we might have created the new group we need to cleanup */
-		osm_mgrp_cleanup(sa->p_subn, p_mgrp);
+		if (is_new_group)
+			osm_mgrp_cleanup(sa->p_subn, p_mgrp);
 		CL_PLOCK_RELEASE(sa->p_lock);
 		OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 1B12: "
 			"validate_more_comp_fields, validate_port_caps, "

@@ -1214,7 +1215,8 @@ static void mcmr_rcv_join_mgrp(IN osm_sa_t * sa, IN osm_madw_t * p_madw)
 					&mcmember_rec, proxy);
 	if (!p_mcmr_port) {
 		/* we fail to add the port so we might need to delete the group */
-		osm_mgrp_cleanup(sa->p_subn, p_mgrp);
+		if (is_new_group)
+			osm_mgrp_cleanup(sa->p_subn, p_mgrp);
 		CL_PLOCK_RELEASE(sa->p_lock);
 		OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 1B06: "
 			"osm_mgrp_add_port failed\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html