Skip to contentSkip to conversation

Staging: rtl8192e: Fix sparse warning

PATCH Superseded Joel Pelaez Jorge 2 participants 2 messages Apr 6, 2014 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Joel Pelaez Jorge

author
#0 lore raw

PATCH 1/1 Staging: rtl8192e: Fix sparse warning

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was not declared. Should it be static

Signed-off-by Joel Pelaez Jorge <[email protected]>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +2 -0
index 498995d..5baa699 100644
@@ -20,6 +20,8 @@
 #include <linux/string.h>
 #include "rtl_core.h"
 
+extern struct iw_handler_def r8192_wx_handlers_def;
+
 #define RATE_COUNT 12
 static u32 rtl8192_rates[] = {
 	1000000, 2000000, 5500000, 11000000, 6000000, 9000000, 12000000,
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 14 lines · Joel Pelaez Jorge

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was not declared. Should it be static

Signed-off-by Joel Pelaez Jorge <[email protected]>
---
  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |    2 ++
  1 file changed, 2 insertions(+)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +0 -0
index 498995d..5baa699 100644

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c line 23

Quoted 4 lines
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +1 -0
@@ -20,6 +20,8 @@
  #include <linux/string.h>
  #include "rtl_core.h"
 
+extern struct iw_handler_def r8192_wx_handlers_def;

Don't put "extern" in a .c file, that's never the correct solution.

thanks,

greg k-h