net phylib: Remove unnecessary condition check
Subsystems (3)
PATCH v2 1/1 net phylib: Remove unnecessary condition check
This condition check makes no difference in the code flow since 3.10
--- drivers/net/phy/phy.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/net/phy/phy.c +0 -0
@@ -756,12 +756,8 @@ void phy_state_machine(struct work_struct *work)
netif_carrier_on(phydev->attached_dev); phydev->adjust_link(phydev->attached_dev);
- } else if (0 == phydev->link_timeout--) {
+ } else if (0 == phydev->link_timeout--)
needs_aneg = 1;
- /* If we have the magic_aneg bit, we try again */
- if (phydev->drv->flags & PHY_HAS_MAGICANEG)
- break;
- }
break; case PHY_NOLINK: err = phy_read_status(phydev);
-- 1.7.9.5
David Miller
maintainerFrom: Balakumaran Kannan <[email protected]>
Date: Tue, 08 Apr 2014 20:51:05 +0530
Quoted 4 lines
This condition check makes no difference in the code flow since 3.10
Signed-off-by Balakumaran Kannan <[email protected]>Reviewed-by Florian Fainelli <[email protected]>
Your patch is still being corrupted by your email client.
Quoted 5 lines
(quoted diff) +0
-4- /* If we have the magic_aneg bit, we try again */ - if (phydev->drv->flags & PHY_HAS_MAGICANEG) - break; - }break;
On that break; line there should be a space then TAB characters in the patch, instead there are only TAB characters.
I'm sorry David. I'll correct those mistakes and send the patch. Sorry for the inconvenience caused.
And thank you very much for your patience and noticing the mistakes clearly.
Regards,
Bala