Skip to contentSkip to conversation

migration dirtybitmap support ARMv7

PATCH In review Mario Smarduch 2 participants 2 messages Apr 15, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 migration dirtybitmap support ARMv7

Headers for migration, prototypes

---
 arch/arm/include/asm/kvm_host.h |    9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/include/asm/kvm_host.h +9 -0
index 098f7dd..9b71f13 100644
@@ -67,6 +67,7 @@ struct kvm_arch {
 
 	/* Interrupt controller */
 	struct vgic_dist	vgic;
+	int migration_in_progress;
 };
 
 #define KVM_NR_MEM_OBJS     40
@@ -228,4 +229,12 @@ int kvm_perf_teardown(void);
 u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid);
 int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value);
 
+void kvm_mmu_slot_remove_write_access(struct kvm *kvm, int slot);
+
+void kvm_mmu_write_protect_pt_masked(struct kvm *kvm,
+		struct kvm_memory_slot *slot,
+		gfn_t gfn_offset, unsigned long mask);
+
+void kvm_tlb_flush_vmid(struct kvm *kvm);
+
 #endif /* __ARM_KVM_HOST_H__ */
Signature · 1 line
1.7.9.5
#1 lore raw

Hi Mario,

Quoted 4 lines · Mario Smarduch

Headers for migration, prototypes

As a general comment in the whole series: Please take the time to write decent commit messages. Having the same title for all three patches is rather counter-productive, and I'd like to be able to tell what each individual patch does just by reading the commit message.

Thanks!

Quoted 20 lines
---
 arch/arm/include/asm/kvm_host.h |    9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/include/asm/kvm_host.h +1 -0
index 098f7dd..9b71f13 100644
@@ -67,6 +67,7 @@ struct kvm_arch {
 
 	/* Interrupt controller */
 	struct vgic_dist	vgic;
+	int migration_in_progress;
 };
 
 #define KVM_NR_MEM_OBJS     40
@@ -228,4 +229,12 @@ int kvm_perf_teardown(void);
 u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid);
 int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value);

arch/arm/include/asm/kvm_host.h int kvm_perf_teardown(void); · line 240

Quoted 10 lines
arch/arm/include/asm/kvm_host.h +8 -0
 
+void kvm_mmu_slot_remove_write_access(struct kvm *kvm, int slot);
+
+void kvm_mmu_write_protect_pt_masked(struct kvm *kvm,
+		struct kvm_memory_slot *slot,
+		gfn_t gfn_offset, unsigned long mask);
+
+void kvm_tlb_flush_vmid(struct kvm *kvm);
+
 #endif /* __ARM_KVM_HOST_H__ */

This doesn't make much sense on its own. Consider squashing it in another patch.

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...