Skip to contentSkip to conversation

tracing/uprobes: fix uprobe_cpu_buffer memory leak

PATCH New zhangwei(Jovi) 1 participant 1 message Apr 17, 2014 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing/uprobes: fix uprobe_cpu_buffer memory leak

Forgot to free uprobe_cpu_buffer percpu page in uprobe_buffer_disable.

---
 kernel/trace/trace_uprobe.c | 6 ++++++
 1 file changed, 6 insertions(+)
kernel/trace/trace_uprobe.c +6 -0
index e447336..071d3bb 100644
@@ -729,9 +729,15 @@ static int uprobe_buffer_enable(void)
 
 static void uprobe_buffer_disable(void)
 {
+	int cpu;
+
 	BUG_ON(!mutex_is_locked(&event_mutex));
 
 	if (--uprobe_buffer_refcnt == 0) {
+		for_each_possible_cpu(cpu)
+			free_page((unsigned long)per_cpu_ptr(uprobe_cpu_buffer,
+							     cpu)->buf);
+
 		free_percpu(uprobe_cpu_buffer);
 		uprobe_cpu_buffer = NULL;
 	}
Signature · 1 line
1.8.3.1