vl: avoid closing stdout with 'writeconfig'
PATCH v2 1/1 vl: avoid closing stdout with 'writeconfig'
'writeconfig' supports output to stdout (with '-'); when that happens, we must not close stdout, or further command line options that also use stdout will be impacted. (Although 'writeconfig' was copied from 'readconfig', the latter does not have the problem because it does not support reading from '-')
Signed-off-by Chen Gang <[email protected]>
Reviewed-by Eric Blake <[email protected]>
--- vl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
vl.c +3 -1
@@ -3855,7 +3855,9 @@ int main(int argc, char **argv, char **envp) } }qemu_config_write (fp); -fclose (fp); +if (fp != stdout) { +fclose (fp); + }break ; }case QEMU_OPTION_qtest:
Signature · 1 line
1.7.11.7
Michael Tokarev
Applied22.04.2014 05:12, Chen Gang wrotr:
Quoted 5 lines
'writeconfig' supports output to stdout (with '-'); when that happens, we must not close stdout, or further command line options that also use stdout will be impacted. (Although 'writeconfig' was copied from 'readconfig', the latter does not have the problem because it does not support reading from '-')
Thanks, applied to -trivial.
/mjt