Skip to contentSkip to conversation

mm: update the comment for high_memory

PATCH In review Wang Sheng-Hui 2 participants 3 messages Apr 27, 2014 – Apr 28, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: update the comment for high_memory

The system variable is not used for x86 only now. Remove the "x86" strings.

---
 mm/memory.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
mm/memory.c +3 -4
index 93e332d..1615a64 100644
@@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
 #endif
 
 /*
- * A number of key systems in x86 including ioremap() rely on the assumption
- * that high_memory defines the upper bound on direct map memory, then end
- * of ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
+ * A number of key systems including ioremap() rely on the assumption that
+ * high_memory defines the upper bound on direct map memory, then end of
+ * ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
  * highstart_pfn must be the same; there must be no gap between ZONE_NORMAL
  * and ZONE_HIGHMEM.
  */
 void * high_memory;
-
 EXPORT_SYMBOL(high_memory);
 
 /*
Signature · 7 lines
1.8.3.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#1 lore raw
Quoted 15 lines · Wang Sheng-Hui

The system variable is not used for x86 only now. Remove the "x86" strings.

---
 mm/memory.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
mm/memory.c +0 -0
index 93e332d..1615a64 100644
@@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
 #endif

mm/memory.c EXPORT_SYMBOL(mem_map); · line 92

Quoted 10 lines
mm/memory.c +3 -3
 
 /*
- * A number of key systems in x86 including ioremap() rely on the assumption
- * that high_memory defines the upper bound on direct map memory, then end
- * of ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
+ * A number of key systems including ioremap() rely on the assumption that
+ * high_memory defines the upper bound on direct map memory, then end of
+ * ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
  * highstart_pfn must be the same; there must be no gap between ZONE_NORMAL
  * and ZONE_HIGHMEM.

ioremap() is not a 'key system', so if we are touching it then the comment should be fixed in other ways as well.

Thanks,

Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#2 lore raw

Got it, Ingo.

Will figure out more fine comment.

2014-04-27 19:46 GMT+08:00 Ingo Molnar <[email protected]>:

Quoted 41 lines · Wang Sheng-Hui
Quoted 15 lines

The system variable is not used for x86 only now. Remove the "x86" strings.

---
 mm/memory.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
mm/memory.c +0 -0
index 93e332d..1615a64 100644

mm/memory.c EXPORT_SYMBOL(mem_map); · line 88

Quoted 4 lines
mm/memory.c +0 -1
@@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
 #endif
 
 /*
- * A number of key systems in x86 including ioremap() rely on the

assumption

mm/memory.c EXPORT_SYMBOL(mem_map); · line 89

Quoted 1 line
mm/memory.c +0 -1
- * that high_memory defines the upper bound on direct map memory, then

end

mm/memory.c EXPORT_SYMBOL(mem_map); · line 90

Quoted 1 line
mm/memory.c +0 -1
- * of ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn

and

mm/memory.c EXPORT_SYMBOL(mem_map); · line 88

Quoted 1 line
mm/memory.c +1 -0
+ * A number of key systems including ioremap() rely on the assumption

that

mm/memory.c EXPORT_SYMBOL(mem_map);

Quoted 3 lines
mm/memory.c +2 -0
+ * high_memory defines the upper bound on direct map memory, then end of
+ * ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
  * highstart_pfn must be the same; there must be no gap between

ZONE_NORMAL

mm/memory.c EXPORT_SYMBOL(mem_map); · line 92

Quoted 1 line
mm/memory.c +0 -0
  * and ZONE_HIGHMEM.

ioremap() is not a 'key system', so if we are touching it then the comment should be fixed in other ways as well.

Thanks,

Ingo