drivers/rtc/rtc-puv3.c: fix 2 typo issues.

PATCH In review Chen Gang 2 participants 5 messages May 3, 2014 – May 12, 2014 Real time clock (RTC)

lore

Share & tools

lore

Chen Gang

author

2014-05-03 05:06 UTC #0 lore raw

cover drivers/rtc/rtc-puv3.c: fix 2 typo issues.

Fix 2 typo issues for commit "1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()".

Signed-off-by Chen Gang <[email protected]>

---
 drivers/rtc/rtc-puv3.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Chen Gang

author

2014-05-03 05:08 UTC #1 lore raw

PATCH 1/2 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue

It is only a typo issue, the related commit:

"1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"

The related error (unicore32 with allmodconfig):

CC [M] drivers/rtc/rtc-puv3.o
drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setpie’:
drivers/rtc/rtc-puv3.c:74: error: implicit declaration of function ‘dev_debug’

Signed-off-by Chen Gang <[email protected]>

---
 drivers/rtc/rtc-puv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/rtc/rtc-puv3.c +1 -1

index 1ecfe3b..c56310e 100644
@@ -71,7 +71,7 @@ static int puv3_rtc_setpie(struct device *dev, int enabled)
 {
 	unsigned int tmp;
 
-	dev_debug(dev, "%s: pie=%d\n", __func__, enabled);
+	dev_dbg(dev, "%s: pie=%d\n", __func__, enabled);
 
 	spin_lock_irq(&puv3_rtc_pie_lock);
 	tmp = readl(RTC_RTSR) & ~RTC_RTSR_HZE;

Signature · 1 line

1.9.2.459.g68773ac

Chen Gang

author

2014-05-03 05:09 UTC #3 lore raw

PATCH 2/2 drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0

In reply to Chen Gang

It is only a typo issue, the related commit:

"1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"

The related error (for unicore32 with allmodconfig):

CC [M] drivers/rtc/rtc-puv3.o
drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setalarm’:
drivers/rtc/rtc-puv3.c:143: error: ‘struct device’ has no member named ‘dev’

Signed-off-by Chen Gang <[email protected]>

---
 drivers/rtc/rtc-puv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/rtc/rtc-puv3.c +1 -1

index c56310e..1cff2a2 100644
@@ -140,7 +140,7 @@ static int puv3_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
 	rtc_tm_to_time(tm, &rtcalarm_count);
 	writel(rtcalarm_count, RTC_RTAR);
 
-	puv3_rtc_setaie(&dev->dev, alrm->enabled);
+	puv3_rtc_setaie(dev, alrm->enabled);
 
 	if (alrm->enabled)
 		enable_irq_wake(puv3_rtc_alarmno);

Signature · 1 line

1.9.2.459.g68773ac

管雪涛

Acked-by Xuetao Guan on v1 1/2

2014-05-12 07:53 UTC #2 lore raw

回复： [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue

In reply to Chen Gang

Acked-by Xuetao Guan <[email protected]>

Quoted 31 lines · ----- Chen Gang

It is only a typo issue, the related commit:
"1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"
The related error (unicore32 with allmodconfig):
CC [M] drivers/rtc/rtc-puv3.o
drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setpie’:
drivers/rtc/rtc-puv3.c:74: error: implicit declaration of function ‘dev_debug’
Signed-off-by Chen Gang <[email protected]>
---
 drivers/rtc/rtc-puv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-puv3.c +1 -1
index 1ecfe3b..c56310e 100644
@@ -71,7 +71,7 @@ static int puv3_rtc_setpie(struct device *dev, int enabled)
 {
 	unsigned int tmp;
 
-	dev_debug(dev, "%s: pie=%d\n", __func__, enabled);
+	dev_dbg(dev, "%s: pie=%d\n", __func__, enabled);
 
 	spin_lock_irq(&puv3_rtc_pie_lock);
 	tmp = readl(RTC_RTSR) & ~RTC_RTSR_HZE;
Signature · 1 line
1.9.2.459.g68773ac

管雪涛

Acked-by Xuetao Guan on v1 2/2

2014-05-12 07:56 UTC #4 lore raw

回复： [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0

In reply to Chen Gang

Acked-by Xuetao Guan <[email protected]>

Quoted 31 lines · ----- Chen Gang

It is only a typo issue, the related commit:
"1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"
The related error (for unicore32 with allmodconfig):
CC [M] drivers/rtc/rtc-puv3.o
drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setalarm’:
drivers/rtc/rtc-puv3.c:143: error: ‘struct device’ has no member named ‘dev’
Signed-off-by Chen Gang <[email protected]>
---
 drivers/rtc/rtc-puv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-puv3.c +1 -1
index c56310e..1cff2a2 100644
@@ -140,7 +140,7 @@ static int puv3_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
 	rtc_tm_to_time(tm, &rtcalarm_count);
 	writel(rtcalarm_count, RTC_RTAR);
 
-	puv3_rtc_setaie(&dev->dev, alrm->enabled);
+	puv3_rtc_setaie(dev, alrm->enabled);
 
 	if (alrm->enabled)
 		enable_irq_wake(puv3_rtc_alarmno);
Signature · 1 line
1.9.2.459.g68773ac