Skip to contentSkip to conversation

Any ideas on how to fix rssi?

DISCUSSION Ben Greear 2 participants 4 messages May 14, 2014 – May 15, 2014 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

I'm seeing incorrect signal strength when running a rate-vs-range test through an attenuator. Maybe the FIXME below is the reason?

Any suggestions on what needs doing here?

Thanks,
Ben

static void ath10k_htt_rx_frag_handler(struct ath10k_htt *htt,
struct htt_rx_fragment_indication *frag)

{
	struct sk_buff *msdu_head, *msdu_tail;
	enum htt_rx_mpdu_encrypt_type enctype;
	struct htt_rx_desc *rxd;
	enum rx_msdu_decap_format fmt;
	struct ieee80211_rx_status *rx_status = &htt->rx_status;
	struct ieee80211_hdr *hdr;
	int ret;
	bool tkip_mic_err;
	bool decrypt_err;
	u8 *fw_desc;
	int fw_desc_len, hdrlen, paramlen;
	int trim;

	fw_desc_len = __le16_to_cpu(frag->fw_rx_desc_bytes);
	fw_desc = (u8 *)frag->fw_msdu_rx_desc;

	msdu_head = NULL;
	msdu_tail = NULL;

	spin_lock_bh(&htt->rx_ring.lock);
	ret = ath10k_htt_rx_amsdu_pop(htt, &fw_desc, &fw_desc_len,
				      &msdu_head, &msdu_tail);
	spin_unlock_bh(&htt->rx_ring.lock);

	ath10k_dbg(ATH10K_DBG_HTT_DUMP, "htt rx frag ahead\n");

	if (ret) {
		ath10k_warn("failed to pop amsdu from httr rx ring for fragmented rx %d\n",
			    ret);
		ath10k_htt_rx_free_msdu_chain(msdu_head);
		return;
	}

	/* FIXME: implement signal strength */
Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#1 lore raw
Quoted 4 lines · Ben Greear

I'm seeing incorrect signal strength when running a rate-vs-range test through an attenuator. Maybe the FIXME below is the reason?

Any suggestions on what needs doing here?

Actually, it wasn't (just?) this...the patch below makes the numbers look good, but obviously there could be a better fix:

drivers/net/wireless/ath/ath10k/htt_rx.c +9 -3
index ccbc363..f26f296 100644
@@ -1218,8 +1218,13 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
        mpdu_ranges = htt_rx_ind_get_mpdu_ranges(rx);
 
        /* Fill this once, while this is per-ppdu */
-       rx_status->signal  = ATH10K_DEFAULT_NOISE_FLOOR;
-       rx_status->signal += rx->ppdu.combined_rssi;
+       if (rx->ppdu.combined_rssi) {
+               rx_status->signal  = ATH10K_DEFAULT_NOISE_FLOOR;
+               rx_status->signal += rx->ppdu.combined_rssi;
+       }
+       else {
+               rx_status->flag |= RX_FLAG_NO_SIGNAL_VAL;
+       }
 
        if (rx->ppdu.info0 & HTT_RX_INDICATION_INFO0_END_VALID) {
                /* TSF available only in 32-bit */
@@ -1342,7 +1347,8 @@ static void ath10k_htt_rx_frag_handler(struct ath10k_htt *htt,
        }
 
        /* FIXME: implement signal strength */
-
+       rx_status->flag |= RX_FLAG_NO_SIGNAL_VAL;
+
        hdr = (struct ieee80211_hdr *)msdu_head->data;
        rxd = (void *)msdu_head->data - sizeof(*rxd);
        tkip_mic_err = !!(__le32_to_cpu(rxd->attention.flags) &
Quoted 44 lines

Thanks,
Ben

static void ath10k_htt_rx_frag_handler(struct ath10k_htt *htt,
struct htt_rx_fragment_indication *frag)

{
	struct sk_buff *msdu_head, *msdu_tail;
	enum htt_rx_mpdu_encrypt_type enctype;
	struct htt_rx_desc *rxd;
	enum rx_msdu_decap_format fmt;
	struct ieee80211_rx_status *rx_status = &htt->rx_status;
	struct ieee80211_hdr *hdr;
	int ret;
	bool tkip_mic_err;
	bool decrypt_err;
	u8 *fw_desc;
	int fw_desc_len, hdrlen, paramlen;
	int trim;

	fw_desc_len = __le16_to_cpu(frag->fw_rx_desc_bytes);
	fw_desc = (u8 *)frag->fw_msdu_rx_desc;

	msdu_head = NULL;
	msdu_tail = NULL;

	spin_lock_bh(&htt->rx_ring.lock);
	ret = ath10k_htt_rx_amsdu_pop(htt, &fw_desc, &fw_desc_len,
				      &msdu_head, &msdu_tail);
	spin_unlock_bh(&htt->rx_ring.lock);

	ath10k_dbg(ATH10K_DBG_HTT_DUMP, "htt rx frag ahead\n");

	if (ret) {
		ath10k_warn("failed to pop amsdu from httr rx ring for fragmented rx %d\n",
			    ret);
		ath10k_htt_rx_free_msdu_chain(msdu_head);
		return;
	}

	/* FIXME: implement signal strength */
Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
Quoted 14 lines · Ben Greear
Quoted 4 lines · Ben Greear

I'm seeing incorrect signal strength when running a rate-vs-range test through an attenuator. Maybe the FIXME below is the reason?

Any suggestions on what needs doing here?

Actually, it wasn't (just?) this...the patch below makes the numbers look good, but obviously there could be a better fix:

drivers/net/wireless/ath/ath10k/htt_rx.c +0 -0
index ccbc363..f26f296 100644

drivers/net/wireless/ath/ath10k/htt_rx.c static void ath10k_htt_rx_handler(struct ath10k_htt *htt, · line 1222

Quoted 5 lines
drivers/net/wireless/ath/ath10k/htt_rx.c +0 -2
@@ -1218,8 +1218,13 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
        mpdu_ranges = htt_rx_ind_get_mpdu_ranges(rx);
 
        /* Fill this once, while this is per-ppdu */
-       rx_status->signal  = ATH10K_DEFAULT_NOISE_FLOOR;
-       rx_status->signal += rx->ppdu.combined_rssi;

Seems you have old code without ath10k: fix rssi and rate reporting patch.

BR
Janusz

Quoted 74 lines
drivers/net/wireless/ath/ath10k/htt_rx.c +9 -1
+       if (rx->ppdu.combined_rssi) {
+               rx_status->signal  = ATH10K_DEFAULT_NOISE_FLOOR;
+               rx_status->signal += rx->ppdu.combined_rssi;
+       }
+       else {
+               rx_status->flag |= RX_FLAG_NO_SIGNAL_VAL;
+       }
 
        if (rx->ppdu.info0 & HTT_RX_INDICATION_INFO0_END_VALID) {
                /* TSF available only in 32-bit */
@@ -1342,7 +1347,8 @@ static void ath10k_htt_rx_frag_handler(struct ath10k_htt *htt,
        }
 
        /* FIXME: implement signal strength */
-
+       rx_status->flag |= RX_FLAG_NO_SIGNAL_VAL;
+
        hdr = (struct ieee80211_hdr *)msdu_head->data;
        rxd = (void *)msdu_head->data - sizeof(*rxd);
        tkip_mic_err = !!(__le32_to_cpu(rxd->attention.flags) &
Quoted 37 lines

Thanks,
Ben

static void ath10k_htt_rx_frag_handler(struct ath10k_htt *htt,
struct htt_rx_fragment_indication *frag)

{
      struct sk_buff *msdu_head, *msdu_tail;
      enum htt_rx_mpdu_encrypt_type enctype;
      struct htt_rx_desc *rxd;
      enum rx_msdu_decap_format fmt;
      struct ieee80211_rx_status *rx_status = &htt->rx_status;
      struct ieee80211_hdr *hdr;
      int ret;
      bool tkip_mic_err;
      bool decrypt_err;
      u8 *fw_desc;
      int fw_desc_len, hdrlen, paramlen;
      int trim;

      fw_desc_len = __le16_to_cpu(frag->fw_rx_desc_bytes);
      fw_desc = (u8 *)frag->fw_msdu_rx_desc;

      msdu_head = NULL;
      msdu_tail = NULL;

      spin_lock_bh(&htt->rx_ring.lock);
      ret = ath10k_htt_rx_amsdu_pop(htt, &fw_desc, &fw_desc_len,
                                    &msdu_head, &msdu_tail);
      spin_unlock_bh(&htt->rx_ring.lock);

      ath10k_dbg(ATH10K_DBG_HTT_DUMP, "htt rx frag ahead\n");
Quoted 10 lines
      if (ret) {
              ath10k_warn("failed to pop amsdu from httr rx ring for fragmented rx %d\n",
                          ret);
              ath10k_htt_rx_free_msdu_chain(msdu_head);
              return;
      }

      /* FIXME: implement signal strength */

--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com

Quoted 4 lines

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

author
#3 lore raw
Quoted 17 lines · Janusz Dziedzic
Quoted 16 lines · Ben Greear
Quoted 4 lines · Ben Greear

I'm seeing incorrect signal strength when running a rate-vs-range test through an attenuator. Maybe the FIXME below is the reason?

Any suggestions on what needs doing here?

Actually, it wasn't (just?) this...the patch below makes the numbers look good, but obviously there could be a better fix:

drivers/net/wireless/ath/ath10k/htt_rx.c +0 -0
index ccbc363..f26f296 100644
@@ -1218,8 +1218,13 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
        mpdu_ranges = htt_rx_ind_get_mpdu_ranges(rx);
 
Quoted 5 lines

drivers/net/wireless/ath/ath10k/htt_rx.c static void ath10k_htt_rx_handler(struct ath10k_htt *htt, · line 1222

Quoted 3 lines
drivers/net/wireless/ath/ath10k/htt_rx.c +0 -2
        /* Fill this once, while this is per-ppdu */
-       rx_status->signal  = ATH10K_DEFAULT_NOISE_FLOOR;
-       rx_status->signal += rx->ppdu.combined_rssi;

Seems you have old code without ath10k: fix rssi and rate reporting patch.

Yes, thanks for the suggestion. I had patches on each side of that one, but somehow I had missed it. Will test with it today.

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k