Skip to contentSkip to conversation

b1169cc69ba: +10060.4% proc-vmstat.numa_pte_updates

tracing Jet Chen 2 participants 2 messages May 15, 2014

lore
Share & tools
lore

Jet Chen

author
#0 lore raw

Hi Steven,

FYI, we noticed the below changes on

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/core commit b1169cc69ba96b124df820904a6d3eb775491d7f ("tracing: Remove mock up poll wait function")

f4874261049e3ab  b1169cc69ba96b124df820904
---------------  -------------------------
       191 ~15%  +10060.4%      19487 ~ 8%  lkp-ne04/dd-write/1HDD-ext4-2dd.4k
       191 ~15%  +10060.4%      19487 ~ 8%  TOTAL proc-vmstat.numa_pte_updates

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

   2419721 ~ 0%     +88.0%    4549654 ~ 2%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
   2419721 ~ 0%     +88.0%    4549654 ~ 2%  TOTAL perf-stat.context-switches

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

       954 ~ 0%     +52.7%       1457 ~ 0%  lkp-ne04/dd-write/1HDD-ext4-2dd.4k
      3932 ~ 0%     +89.1%       7438 ~ 2%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
      4887 ~ 0%     +82.0%       8895 ~ 2%  TOTAL vmstat.system.cs

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

    163477 ~ 0%     +60.1%     261769 ~ 0%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
    163477 ~ 0%     +60.1%     261769 ~ 0%  TOTAL perf-stat.cpu-migrations

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

     28742 ~ 0%      +6.4%      30574 ~ 0%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
     28742 ~ 0%      +6.4%      30574 ~ 0%  TOTAL vmstat.system.in

Legend:
~XX% - stddev percent
[+-]XX% - change percent

Thanks,
Jet

echo performance > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu10/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu11/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu12/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu13/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu14/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu15/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu2/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu4/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu5/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu6/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu7/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu8/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu9/cpufreq/scaling_governor mkfs -t ext4 -q /dev/sda2
echo 1 > /sys/kernel/debug/tracing/events/writeback/balance_dirty_pages/enable echo 1 > /sys/kernel/debug/tracing/events/writeback/bdi_dirty_ratelimit/enable echo 1 > /sys/kernel/debug/tracing/events/writeback/global_dirty_state/enable echo 1 > /sys/kernel/debug/tracing/events/writeback/writeback_single_inode/enable mount -t ext4 /dev/sda2 /fs/sda2
dd bs=4k if=/dev/zero of=/fs/sda2/zero-1 status=none &
dd bs=4k if=/dev/zero of=/fs/sda2/zero-2 status=none &
sleep 600
killall -9 dd

#1 lore raw
Quoted 6 lines · On Thu, 15 May 2014 12:06:26 +0800 Jet Chen <[email protected]> wrote:

Hi Steven,

FYI, we noticed the below changes on

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/core commit b1169cc69ba96b124df820904a6d3eb775491d7f ("tracing: Remove mock up poll wait function")

I have to apologize as I'm not familiar with this benchmark.

Quoted 19 lines
f4874261049e3ab  b1169cc69ba96b124df820904
---------------  -------------------------
       191 ~15%  +10060.4%      19487 ~ 8%  lkp-ne04/dd-write/1HDD-ext4-2dd.4k
       191 ~15%  +10060.4%      19487 ~ 8%  TOTAL proc-vmstat.numa_pte_updates

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

   2419721 ~ 0%     +88.0%    4549654 ~ 2%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
   2419721 ~ 0%     +88.0%    4549654 ~ 2%  TOTAL perf-stat.context-switches

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

       954 ~ 0%     +52.7%       1457 ~ 0%  lkp-ne04/dd-write/1HDD-ext4-2dd.4k
      3932 ~ 0%     +89.1%       7438 ~ 2%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
      4887 ~ 0%     +82.0%       8895 ~ 2%  TOTAL vmstat.system.cs

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

Quoted 7 lines
    163477 ~ 0%     +60.1%     261769 ~ 0%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
    163477 ~ 0%     +60.1%     261769 ~ 0%  TOTAL perf-stat.cpu-migrations

f4874261049e3ab b1169cc69ba96b124df820904
--------------- -------------------------

     28742 ~ 0%      +6.4%      30574 ~ 0%  lkp-ws02/dd-write/11HDD-JBOD-cfq-xfs-1dd
     28742 ~ 0%      +6.4%      30574 ~ 0%  TOTAL vmstat.system.in

What exactly is being measured here? What tool is running?

The change removed a brain dead way of blocking on the ring buffer, which, if there was no data, it would sleep for 100ms and try again, even if no event happened.

The new way is to act more like a real pipe. That is, if there's no data, you will block but as soon as data comes in, you are woken and can read the data. If data is coming in at a steady pace, every read will wake up more often to get that data. More will happen which is a good thing as the old way was to wait 100ms and by then, the tracing could easily overflow the ring buffer.

Perhaps we could add water marks, that is, only wake up if the ring buffer is partially full.

-- Steve

Quoted 11 lines

Legend:
~XX% - stddev percent
[+-]XX% - change percent

Thanks,
Jet