NFSD: Cleanup unneeded including linux/user_namespace.h

PATCH Applied Kinglong Mee 2 participants 3 messages May 23, 2014

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Kinglong Mee

author

2014-05-23 12:53 UTC #0 lore raw

PATCH 1/5 NFSD: Cleanup unneeded including linux/user_namespace.h

commit 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 using kuid/kgid for ex_anon_uid/ex_anon_gid, user_namespace.h is not needed now, clean it.

Signed-off-by Kinglong Mee <[email protected]>

---
 fs/nfsd/auth.c | 1 -
 1 file changed, 1 deletion(-)

fs/nfsd/auth.c +0 -1

index 2645be4..1042325 100644
@@ -1,7 +1,6 @@
 /* Copyright (C) 1995, 1996 Olaf Kirch <[email protected]> */
 
 #include <linux/sched.h>
-#include <linux/user_namespace.h>
 #include "nfsd.h"
 #include "auth.h"

Signature · 1 line

1.9.3

J. Bruce Fields

Applied

2014-05-23 14:18 UTC #1 lore raw

Thanks, applied all five.

Quoted 1 line · Kinglong Mee

commit 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 using kuid/kgid for

In future, when referring to another commit, could you also include the summary line? E.g.: Commit 8f6c5ffc8987 ("kernel/groups.c: remove return value of set_groups") removed the last use of "ret"....

--b.

Quoted 22 lines

ex_anon_uid/ex_anon_gid, user_namespace.h is not needed now, clean it.
Signed-off-by Kinglong Mee <[email protected]>
---
 fs/nfsd/auth.c | 1 -
 1 file changed, 1 deletion(-)
fs/nfsd/auth.c +0 -1
index 2645be4..1042325 100644
@@ -1,7 +1,6 @@
 /* Copyright (C) 1995, 1996 Olaf Kirch <[email protected]> */
 
 #include <linux/sched.h>
-#include <linux/user_namespace.h>
 #include "nfsd.h"
 #include "auth.h"
 
Signature · 1 line
1.9.3

Kinglong Mee

author

2014-05-23 14:21 UTC #2 lore raw

Quoted 8 lines · J. Bruce Fields

Thanks, applied all five.
Quoted 1 line · Kinglong Mee
commit 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 using kuid/kgid for
In future, when referring to another commit, could you also include the summary line? E.g.: Commit 8f6c5ffc8987 ("kernel/groups.c: remove return value of set_groups") removed the last use of "ret"....

Got it, i will do that in the future.

thanks,
Kinglong Mee

Quoted 26 lines

--b.
Quoted 22 lines
ex_anon_uid/ex_anon_gid, user_namespace.h is not needed now, clean it.
Signed-off-by Kinglong Mee <[email protected]>
---
 fs/nfsd/auth.c | 1 -
 1 file changed, 1 deletion(-)
fs/nfsd/auth.c +0 -1
index 2645be4..1042325 100644
@@ -1,7 +1,6 @@
 /* Copyright (C) 1995, 1996 Olaf Kirch <[email protected]> */
 
 #include <linux/sched.h>
-#include <linux/user_namespace.h>
 #include "nfsd.h"
 #include "auth.h"
 
Signature · 1 line
1.9.3