arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

PATCH In review Chen Gang 2 participants 9 messages May 27, 2014

Share & tools

Chen Gang

author

2014-05-27 00:02 UTC #0 lore raw

cover arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

unicore32 has implemented 'find_first_bit', 'find_first_zero_bit', 'pm_power_off', and '__cpuc_coherent_kern_range', need export them to avoid compiling failure.

The related error (with allmodconfig under unicore32):

MODPOST 4039 modules
ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined! [...]
ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined! [...]

Signed-off-by Chen Gang <[email protected]>

---
 arch/unicore32/kernel/ksyms.c   | 2 ++
 arch/unicore32/kernel/process.c | 1 +
 arch/unicore32/mm/proc-syms.c   | 2 ++
 3 files changed, 5 insertions(+)

Thanks.

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Chen Gang

author

2014-05-27 00:03 UTC #1 lore raw

PATCH 1/3 arch: unicore32: ksyms: export additional find_first_*() to avoid compiling failure

Some modules need find_first_bit() and find_first_zero_bit(), so export them.

The related error (with allmodconfig under unicore32):

MODPOST 4039 modules
ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
...

Signed-off-by Chen Gang <[email protected]>

---
 arch/unicore32/kernel/ksyms.c | 2 ++
 1 file changed, 2 insertions(+)

arch/unicore32/kernel/ksyms.c +2 -0

index e78911a..0323528 100644
@@ -23,6 +23,8 @@
 
 #include "ksyms.h"
 
+EXPORT_SYMBOL(find_first_bit);
+EXPORT_SYMBOL(find_first_zero_bit);
 EXPORT_SYMBOL(find_next_zero_bit);
 EXPORT_SYMBOL(find_next_bit);

Signature · 1 line

1.9.2.459.g68773ac

Chen Gang

author

2014-05-27 00:04 UTC #3 lore raw

PATCH 2/3 arch: unicore32: ksyms: export 'pm_power_off' to avoid compiling failure.

In reply to Chen Gang

Two driver modules need 'pm_power_off', so export it.

The related error (with allmodconfig under unicore32):

MODPOST 4039 modules
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!

Signed-off-by Chen Gang <[email protected]>

---
 arch/unicore32/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

arch/unicore32/kernel/process.c +1 -0

index 778ebba..b008e99 100644
@@ -60,6 +60,7 @@ void machine_halt(void)
  * Function pointers to optional machine specific functions
  */
 void (*pm_power_off)(void) = NULL;
+EXPORT_SYMBOL(pm_power_off);
 
 void machine_power_off(void)
 {

Signature · 1 line

1.9.2.459.g68773ac

Chen Gang

author

2014-05-27 00:08 UTC #5 lore raw

PATCH 3/3 arch: unicore32: ksyms: export '__cpuc_coherent_kern_range' to avoid compiling failure

In reply to Chen Gang

flush_icache_range() is '__cpuc_coherent_kern_range' under unicore32, and lkdtm.ko needs it. At present, '__cpuc_coherent_kern_range' is still used by unicore32, so export it to avoid compiling failure.

The related error (with allmodconfig under unicore32):

ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!

Signed-off-by Chen Gang <[email protected]>

---
 arch/unicore32/mm/proc-syms.c | 2 ++
 1 file changed, 2 insertions(+)

arch/unicore32/mm/proc-syms.c +2 -0

index f30071e..21c00fc 100644
@@ -19,5 +19,7 @@
 EXPORT_SYMBOL(cpu_dcache_clean_area);
 EXPORT_SYMBOL(cpu_set_pte);
 
+EXPORT_SYMBOL(__cpuc_coherent_kern_range);
+
 EXPORT_SYMBOL(__cpuc_dma_flush_range);
 EXPORT_SYMBOL(__cpuc_dma_clean_range);

Signature · 1 line

1.9.2.459.g68773ac

管雪涛

2014-05-27 00:13 UTC #7 lore raw

In reply to Chen Gang

Quoted 14 lines · ----- Chen Gang

unicore32 has implemented 'find_first_bit', 'find_first_zero_bit', 'pm_power_off', and '__cpuc_coherent_kern_range', need export them to avoid compiling failure.
The related error (with allmodconfig under unicore32):
MODPOST 4039 modules
ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined! [...]
ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined! [...]

Quoted 1 line

Signed-off-by Chen Gang <[email protected]>

Thanks, I'm waiting for these patches.
And then, I can request-pull in this month.

Xuetao

Quoted 12 lines

---
 arch/unicore32/kernel/ksyms.c   | 2 ++
 arch/unicore32/kernel/process.c | 1 +
 arch/unicore32/mm/proc-syms.c   | 2 ++
 3 files changed, 5 insertions(+)

Thanks.

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

管雪涛

Acked-by Xuetao Guan on v1 1/3

2014-05-27 00:13 UTC #2 lore raw

回复： [PATCH 1/3] arch: unicore32: ksyms: export additional find_first_*() to avoid compiling failure

In reply to Chen Gang

Quoted 5 lines · ----- Chen Gang

Some modules need find_first_bit() and find_first_zero_bit(), so export them.
The related error (with allmodconfig under unicore32):

Quoted 7 lines

MODPOST 4039 modules
ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
...
Signed-off-by Chen Gang <[email protected]>

Acked-by Xuetao Guan <[email protected]>

Quoted 19 lines

---
 arch/unicore32/kernel/ksyms.c | 2 ++
 1 file changed, 2 insertions(+)

arch/unicore32/kernel/ksyms.c +2 -0

index e78911a..0323528 100644
@@ -23,6 +23,8 @@
 
 #include "ksyms.h"
 
+EXPORT_SYMBOL(find_first_bit);
+EXPORT_SYMBOL(find_first_zero_bit);
 EXPORT_SYMBOL(find_next_zero_bit);
 EXPORT_SYMBOL(find_next_bit);

Signature · 1 line

1.9.2.459.g68773ac

管雪涛

Acked-by Xuetao Guan on v1 2/3

2014-05-27 00:14 UTC #4 lore raw

回复： [PATCH 2/3] arch: unicore32: ksyms: export 'pm_power_off' to avoid compiling failure.

In reply to Chen Gang

Quoted 10 lines · ----- Chen Gang

Two driver modules need 'pm_power_off', so export it.
The related error (with allmodconfig under unicore32):
MODPOST 4039 modules
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
Signed-off-by Chen Gang <[email protected]>

Acked-by Xuetao Guan <[email protected]>

Quoted 18 lines

---
 arch/unicore32/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

arch/unicore32/kernel/process.c +1 -0

index 778ebba..b008e99 100644
@@ -60,6 +60,7 @@ void machine_halt(void)
  * Function pointers to optional machine specific functions
  */
 void (*pm_power_off)(void) = NULL;
+EXPORT_SYMBOL(pm_power_off);
 
 void machine_power_off(void)
 {

Signature · 1 line

1.9.2.459.g68773ac

管雪涛

Acked-by Xuetao Guan on v1 3/3

2014-05-27 00:14 UTC #6 lore raw

回复： [PATCH 3/3] arch: unicore32: ksyms: export '__cpuc_coherent_kern_range' to avoid compiling failure

In reply to Chen Gang

Quoted 10 lines · ----- Chen Gang

flush_icache_range() is '__cpuc_coherent_kern_range' under unicore32, and lkdtm.ko needs it. At present, '__cpuc_coherent_kern_range' is still used by unicore32, so export it to avoid compiling failure.
The related error (with allmodconfig under unicore32):
ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
Signed-off-by Chen Gang <[email protected]>

Acked-by Xuetao Guan <[email protected]>

Quoted 18 lines

---
 arch/unicore32/mm/proc-syms.c | 2 ++
 1 file changed, 2 insertions(+)

arch/unicore32/mm/proc-syms.c +2 -0

index f30071e..21c00fc 100644
@@ -19,5 +19,7 @@
 EXPORT_SYMBOL(cpu_dcache_clean_area);
 EXPORT_SYMBOL(cpu_set_pte);
 
+EXPORT_SYMBOL(__cpuc_coherent_kern_range);
+
 EXPORT_SYMBOL(__cpuc_dma_flush_range);
 EXPORT_SYMBOL(__cpuc_dma_clean_range);

Signature · 1 line

1.9.2.459.g68773ac

Chen Gang

author

2014-05-27 00:32 UTC #8 lore raw

In reply to 管雪涛

Quoted 15 lines · 管雪涛

Quoted 14 lines · ----- Chen Gang
unicore32 has implemented 'find_first_bit', 'find_first_zero_bit', 'pm_power_off', and '__cpuc_coherent_kern_range', need export them to avoid compiling failure.
The related error (with allmodconfig under unicore32):
MODPOST 4039 modules
ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined! [...]
ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined! [...]

Quoted 5 lines

Quoted 1 line
Signed-off-by Chen Gang <[email protected]>
Thanks, I'm waiting for these patches.
And then, I can request-pull in this month.

Thank you for your work. Hope we can finish within this month. And next month, I shall start another architectures.

But I am still very glad to continue to provide contributions for unicore32, and as far as I know:

- allmodconfig under unicore32 finds many warnings which I skipped now. (just like allmodconfig under another architectures without '-W')

- open source unicore32 qemu still need guys to continue.

- open source unicore32 cross-compiler still need guys to continue.

If I have chance for them, I shall try (at present, I have started providing contribution to qemu, and just starting for toolchain, and will start for kvm/xen in 3rd or 4th quater 2014).

Thanks.

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed