Skip to contentSkip to conversation

About only one Signed-of-by for the patches

Consult Chen Gang 3 participants 6 messages May 27, 2014 – May 28, 2014 Linux-next tree

lore
Share & tools
lore

Chen Gang

author Acked-by Xuetao Guan
#0 lore raw

Hello Maintainers:

I find some of patches are only Signed-of-by me, are they OK?

e.g:

commit d7de15786d1a10fa18b80fd44026d442e7a84bd2

Author: Chen Gang <[email protected]>
Date:   Tue Apr 15 09:21:30 2014 +0800

arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM

unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like some of other architectures have done (e.g. arm, powerpc, x86 ...).

The related error with allmodconfig:

CC drivers/char/mem.o
drivers/char/mem.c: In function â<U+0080><U+0098>range_is_allowedâ<U+0080><U+0099>:
drivers/char/mem.c:69: error: implicit declaration of function â<U+0080><U+0098>devmem_is_allowedâ<U+0080><U+0099> make[2]: *** [drivers/char/mem.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

Signed-off-by Chen Gang <[email protected]>
Acked-by Xuetao Guan <[email protected]>

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
#1 lore raw

Hi Chen,

Quoted 2 lines · On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <[email protected]> wrote:

I find some of patches are only Signed-of-by me, are they OK?

Actually, this one is not OK. Anyone who handles a patch needs to add a Signed-off-by. In the case below, that patch was commited to the tree by Guan Xuetao <[email protected]>, so there needs to be a Signed-off-by from them as well.

The same is true for all the commits in the unicore32 tree ...

Quoted 20 lines

commit d7de15786d1a10fa18b80fd44026d442e7a84bd2

Author: Chen Gang <[email protected]>
Date:   Tue Apr 15 09:21:30 2014 +0800

arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM

unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like some of other architectures have done (e.g. arm, powerpc, x86 ...).

The related error with allmodconfig:

CC drivers/char/mem.o
drivers/char/mem.c: In function â<U+0080><U+0098>range_is_allowedâ<U+0080><U+0099>:
drivers/char/mem.c:69: error: implicit declaration of function â<U+0080><U+0098>devmem_is_allowedâ<U+0080><U+0099> make[2]: *** [drivers/char/mem.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

Signed-off-by Chen Gang <[email protected]>
Acked-by Xuetao Guan <[email protected]>
Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
author
#2 lore raw
Quoted 4 lines · Stephen Rothwell

Hi Chen,

Quoted 1 line · On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <[email protected]> wrote:
Quoted 9 lines
Quoted 1 line

I find some of patches are only Signed-of-by me, are they OK?

Actually, this one is not OK. Anyone who handles a patch needs to add a Signed-off-by. In the case below, that patch was commited to the tree by Guan Xuetao <[email protected]>, so there needs to be a Signed-off-by from them as well.

The same is true for all the commits in the unicore32 tree ...

OK, thanks.

Hello Guan Xuetao:

Please help process them, when you have time.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
#3 lore raw
In reply to Stephen Rothwell
Quoted 4 lines · ----- Stephen Rothwell

Hi Chen,

Quoted 1 line · On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <[email protected]> wrote:
Quoted 8 lines
Quoted 1 line

I find some of patches are only Signed-of-by me, are they OK?

Actually, this one is not OK. Anyone who handles a patch needs to add a Signed-off-by. In the case below, that patch was commited to the tree by Guan Xuetao <[email protected]>, so there needs to be a Signed-off-by from them as well.

The same is true for all the commits in the unicore32 tree ...

Ok, I see.

Then, do I need to reply each mail with my sob? Or only replace acked-by by sob for all commits in my tree?

Xuetao

Quoted 25 lines
Quoted 21 lines

commit d7de15786d1a10fa18b80fd44026d442e7a84bd2

Author: Chen Gang <[email protected]>
Date:   Tue Apr 15 09:21:30 2014 +0800

arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM

unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like some of other architectures have done (e.g. arm, powerpc, x86 ...).

The related error with allmodconfig:

CC drivers/char/mem.o
drivers/char/mem.c: In function â<U+0080><U+0098>range_is_allowedâ<U+0080><U+0099>:
drivers/char/mem.c:69: error: implicit declaration of function â<U+0080><U+0098>devmem_is_allowedâ<U+0080><U+0099> make[2]: *** [drivers/char/mem.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

Signed-off-by Chen Gang <[email protected]>
Acked-by Xuetao Guan <[email protected]>
Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#4 lore raw

Hi,

Quoted 14 lines · On Tue, 27 May 2014 13:07:30 +0800 (CST) Xuetao Guan <[email protected]> wrote:
Quoted 11 lines · ----- Stephen Rothwell

Hi Chen,

Quoted 2 lines · On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <[email protected]> wrote:

I find some of patches are only Signed-of-by me, are they OK?

Actually, this one is not OK. Anyone who handles a patch needs to add a Signed-off-by. In the case below, that patch was commited to the tree by Guan Xuetao <[email protected]>, so there needs to be a Signed-off-by from them as well.

Quoted 5 lines
Quoted 1 line

The same is true for all the commits in the unicore32 tree ...

Ok, I see.

Then, do I need to reply each mail with my sob? Or only replace acked-by by sob for all commits in my tree?

You do not need to reply to each email, but any patch that you send on to Linus (or someone else) needs to have your Signed-off-by. Please read the "Developer's Certificate of Origin" in section 12 of Documentation/SubmittingPatches.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#5 lore raw
Quoted 19 lines · ----- Stephen Rothwell

Hi,

Quoted 16 lines · On Tue, 27 May 2014 13:07:30 +0800 (CST) Xuetao Guan <[email protected]> wrote:
Quoted 12 lines · ----- Stephen Rothwell

Hi Chen,

Quoted 2 lines · On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <[email protected]> wrote:

I find some of patches are only Signed-of-by me, are they OK?

Actually, this one is not OK. Anyone who handles a patch needs to add a Signed-off-by. In the case below, that patch was commited to the tree by Guan Xuetao <[email protected]>, so there needs to be a Signed-off-by from them as well.

The same is true for all the commits in the unicore32 tree ...

Quoted 11 lines
Quoted 3 lines

Ok, I see.

Then, do I need to reply each mail with my sob? Or only replace acked-by by sob for all commits in my tree?

You do not need to reply to each email, but any patch that you send on to Linus (or someone else) needs to have your Signed-off-by. Please read the "Developer's Certificate of Origin" in section 12 of Documentation/SubmittingPatches.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]

I see. What I misunderstood is that acked-by had similar functions. Thanks.

Xuetao