Skip to contentSkip to conversation

rcu alignment warning tripping on m68k

PATCH Greg Ungerer 4 participants 7 messages May 29, 2014 – Jun 10, 2014 RCU

lore
Share & tools
lore
#0 lore raw

Hi All,

Inside kernel/rcy/tree.c in __call_rcu() it does an alignment check on the head pointer passed in. This trips on m68k systems, because they only need alignment of 32bit quantities to 16bit boundaries.

...
UDP hash table entries: 512 (order: 0, 8192 bytes) UDP-Lite hash table entries: 512 (order: 0, 8192 bytes)
NET: Registered protocol family 1
ROMFS MTD (C) 2007 Red Hat, Inc.

------------[ cut here ]------------
WARNING: CPU: 0 PID: 18 at kernel/rcu/tree.c:2470 0x400577e0()
Modules linked in:
CPU: 0 PID: 18 Comm: kworker/u2:0 Not tainted 3.15.0-rc4-00013-g1c07b64-dirty #14
Stack from 418ada9c:
        418ada9c 401e8336 400258e0 401c69c4 418ac000 418a86f6 4003bc0a 418a8390
        418a86f6 4002590e 401e176b 000009a6 400577e0 00000009 00000000 400577e0
        401e176b 000009a6 401c69c4 418ac000 418a8390 418a8390 418ac000 40057928
        418a86f6 40025bcc 40218fe0 00000000 401ddb56 401e17ad 000002af 400261c2
        418a86f6 40025bcc 00000013 00000030 00000010 00000013 418ac000 418adf88
        418a8390 418adf70 400263f0 418a8000 418adf18 41885950 00000000 00000000
Call Trace:
        [<400258e0>] 0x400258e0
 [<401c69c4>] 0x401c69c4
 [<4003bc0a>] 0x4003bc0a
 [<4002590e>] 0x4002590e
 [<400577e0>] 0x400577e0

What is the best solution to fix?
Make the alignment check be only 16bits?

kernel/rcu/tree.c +1 -1
@@ -2467,7 +2467,7 @@ __call_rcu(struct rcu_head *head, void (*func)(struct rcu_
        unsigned long flags;
        struct rcu_data *rdp;
 
-       WARN_ON_ONCE((unsigned long)head & 0x3); /* Misaligned rcu_head! */
+       WARN_ON_ONCE((unsigned long)head & 0x1); /* Misaligned rcu_head! */
        if (debug_rcu_head_queue(head)) {
                /* Probable double call_rcu(), so leak the callback. */
                ACCESS_ONCE(head->func) = rcu_leak_callback;

Or should we just get rid of this check altogether?

Regards
Greg

#1 lore raw
Quoted 5 lines · On Thu, 29 May 2014 12:08:32 +1000 Greg Ungerer <[email protected]> wrote:

Hi All,

Inside kernel/rcy/tree.c in __call_rcu() it does an alignment check on the head pointer passed in. This trips on m68k systems, because they only need alignment of 32bit quantities to 16bit boundaries.

__alignof perhaps ?

or just an ARCH_ define ?

#2 lore raw
Quoted 10 lines · One Thousand Gnomes
Quoted 5 lines · On Thu, 29 May 2014 12:08:32 +1000 Greg Ungerer <[email protected]> wrote:

Hi All,

Inside kernel/rcy/tree.c in __call_rcu() it does an alignment check on the head pointer passed in. This trips on m68k systems, because they only need alignment of 32bit quantities to 16bit boundaries.

__alignof perhaps ?

That might do. Change then becomes something like:

kernel/rcu/tree.c +1 -1
@@ -2467,7 +2467,7 @@ __call_rcu(struct rcu_head *head, void (*func)(struct rcu_
        unsigned long flags;
        struct rcu_data *rdp;
 
-       WARN_ON_ONCE((unsigned long)head & 0x3); /* Misaligned rcu_head! */
+       WARN_ON_ONCE((unsigned long)head & (__alignof__(head) - 1)); /* Misaligned rcu_head! */
        if (debug_rcu_head_queue(head)) {
                /* Probable double call_rcu(), so leak the callback. */
                ACCESS_ONCE(head->func) = rcu_leak_callback;

Thanks
Greg

#3 lore raw
Quoted 17 lines · Greg Ungerer
Quoted 10 lines · One Thousand Gnomes
Quoted 5 lines · On Thu, 29 May 2014 12:08:32 +1000 Greg Ungerer <[email protected]> wrote:

Hi All,

Inside kernel/rcy/tree.c in __call_rcu() it does an alignment check on the head pointer passed in. This trips on m68k systems, because they only need alignment of 32bit quantities to 16bit boundaries.

__alignof perhaps ?

That might do. Change then becomes something like:

kernel/rcu/tree.c __call_rcu(struct rcu_head *head, void (*func)(struct rcu_ · line 2470

Quoted 5 lines
kernel/rcu/tree.c +1 -1
@@ -2467,7 +2467,7 @@ __call_rcu(struct rcu_head *head, void (*func)(struct rcu_
        unsigned long flags;
        struct rcu_data *rdp;
 
-       WARN_ON_ONCE((unsigned long)head & 0x3); /* Misaligned rcu_head! */
+       WARN_ON_ONCE((unsigned long)head & (__alignof__(head) - 1)); /* Misaligned rcu_head! */

Hmmm... The purpose of the check is to reserve the low-order bits to allow RCU to classify callbacks as being time-critical or not. RCU can probably live with a single bit, but if there is some architecture out there that simply refuses to do alignment, I need to know about it.

(See "git show 0bb7b59d6e2b8" for more info.)

So how about this instead?

- WARN_ON_ONCE((unsigned long)head & 0x1); /* Misaligned rcu_head! */

(Trying to remember if I have seen Linux kernel code that uses both the lower bits...)

Thanx, Paul

Quoted 14 lines
kernel/rcu/tree.c +0 -0
        if (debug_rcu_head_queue(head)) {
                /* Probable double call_rcu(), so leak the callback. */
                ACCESS_ONCE(head->func) = rcu_leak_callback;

Thanks
Greg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw
Quoted 29 lines · Paul E. McKenney
Quoted 17 lines · Greg Ungerer
Quoted 10 lines · One Thousand Gnomes
Quoted 5 lines · On Thu, 29 May 2014 12:08:32 +1000 Greg Ungerer <[email protected]> wrote:

Hi All,

Inside kernel/rcy/tree.c in __call_rcu() it does an alignment check on the head pointer passed in. This trips on m68k systems, because they only need alignment of 32bit quantities to 16bit boundaries.

__alignof perhaps ?

That might do. Change then becomes something like:

kernel/rcu/tree.c __call_rcu(struct rcu_head *head, void (*func)(struct rcu_ · line 2470

Quoted 5 lines
kernel/rcu/tree.c +1 -1
@@ -2467,7 +2467,7 @@ __call_rcu(struct rcu_head *head, void (*func)(struct rcu_
        unsigned long flags;
        struct rcu_data *rdp;
 
-       WARN_ON_ONCE((unsigned long)head & 0x3); /* Misaligned rcu_head! */
+       WARN_ON_ONCE((unsigned long)head & (__alignof__(head) - 1)); /* Misaligned rcu_head! */

Hmmm... The purpose of the check is to reserve the low-order bits to allow RCU to classify callbacks as being time-critical or not. RCU can probably live with a single bit, but if there is some architecture out there that simply refuses to do alignment, I need to know about it.

Quoted 8 lines

(See "git show 0bb7b59d6e2b8" for more info.)

So how about this instead?

- WARN_ON_ONCE((unsigned long)head & 0x1); /* Misaligned rcu_head! */

(Trying to remember if I have seen Linux kernel code that uses both the lower bits...)

As stated above, m68k-linux aligns to 16-bit boundaries by default, so you'd get one bit but not necessarily more. If you want more free low bits, why not attach an explicit attribute aligned to the rcu_head type declaration?

#5 lore raw
Quoted 34 lines · Mikael Pettersson
Quoted 33 lines · Paul E. McKenney
Quoted 17 lines · Greg Ungerer
Quoted 10 lines · One Thousand Gnomes
Quoted 5 lines · On Thu, 29 May 2014 12:08:32 +1000 Greg Ungerer <[email protected]> wrote:

Hi All,

Inside kernel/rcy/tree.c in __call_rcu() it does an alignment check on the head pointer passed in. This trips on m68k systems, because they only need alignment of 32bit quantities to 16bit boundaries.

__alignof perhaps ?

That might do. Change then becomes something like:

kernel/rcu/tree.c __call_rcu(struct rcu_head *head, void (*func)(struct rcu_ · line 2470

Quoted 5 lines
kernel/rcu/tree.c +1 -1
@@ -2467,7 +2467,7 @@ __call_rcu(struct rcu_head *head, void (*func)(struct rcu_
        unsigned long flags;
        struct rcu_data *rdp;
 
-       WARN_ON_ONCE((unsigned long)head & 0x3); /* Misaligned rcu_head! */
+       WARN_ON_ONCE((unsigned long)head & (__alignof__(head) - 1)); /* Misaligned rcu_head! */

Hmmm... The purpose of the check is to reserve the low-order bits to allow RCU to classify callbacks as being time-critical or not. RCU can probably live with a single bit, but if there is some architecture out there that simply refuses to do alignment, I need to know about it.

(See "git show 0bb7b59d6e2b8" for more info.)

So how about this instead?

Quoted 8 lines
Quoted 4 lines

- WARN_ON_ONCE((unsigned long)head & 0x1); /* Misaligned rcu_head! */

(Trying to remember if I have seen Linux kernel code that uses both the lower bits...)

As stated above, m68k-linux aligns to 16-bit boundaries by default, so you'd get one bit but not necessarily more. If you want more free low bits, why not attach an explicit attribute aligned to the rcu_head type declaration?

One bit should do it for the time being, but yes, if I ever need two bits, your suggestion of explicitly aligning the rcu_head type declaration sounds like a very good one.

Thanx, Paul

#6 lore raw
In reply to Paul E. McKenney

Hi Paul,

Quoted 21 lines · Paul E. McKenney
Quoted 20 lines · Greg Ungerer
Quoted 10 lines · One Thousand Gnomes
Quoted 5 lines · On Thu, 29 May 2014 12:08:32 +1000 Greg Ungerer <[email protected]> wrote:

Hi All,

Inside kernel/rcy/tree.c in __call_rcu() it does an alignment check on the head pointer passed in. This trips on m68k systems, because they only need alignment of 32bit quantities to 16bit boundaries.

__alignof perhaps ?

That might do. Change then becomes something like:

kernel/rcu/tree.c +0 -0
@@ -2467,7 +2467,7 @@ __call_rcu(struct rcu_head *head, void (*func)(struct rcu_
        unsigned long flags;
        struct rcu_data *rdp;
 
Quoted 7 lines

kernel/rcu/tree.c __call_rcu(struct rcu_head *head, void (*func)(struct rcu_ · line 2470

Quoted 2 lines
kernel/rcu/tree.c +1 -1
-       WARN_ON_ONCE((unsigned long)head & 0x3); /* Misaligned rcu_head! */
+       WARN_ON_ONCE((unsigned long)head & (__alignof__(head) - 1)); /* Misaligned rcu_head! */

Hmmm... The purpose of the check is to reserve the low-order bits to allow RCU to classify callbacks as being time-critical or not. RCU can probably live with a single bit, but if there is some architecture out there that simply refuses to do alignment, I need to know about it.

This change was prompted by this check tripping, so the alignment issue is certainly real for m68k.

Regards
Greg

Quoted 27 lines

(See "git show 0bb7b59d6e2b8" for more info.)

So how about this instead?

- WARN_ON_ONCE((unsigned long)head & 0x1); /* Misaligned rcu_head! */

(Trying to remember if I have seen Linux kernel code that uses both the lower bits...)

Thanx, Paul

Quoted 14 lines
kernel/rcu/tree.c +0 -0
        if (debug_rcu_head_queue(head)) {
                /* Probable double call_rcu(), so leak the callback. */
                ACCESS_ONCE(head->func) = rcu_leak_callback;

Thanks
Greg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/