Input: edt-ft5x06 - fix an i2c write for M09 support
Subsystems (3)
PATCH 1/1 Input: edt-ft5x06 - fix an i2c write for M09 support
Hi all.
I received notice from Robert Wörle who spotted a bug in the ft5x06 driver (M09 support) which can result in bogus values being written into the configuration registers.
Quoted 11 lines · Paul
I think i found the problem, as the driver sends 3 bytes instead of 2 when accessing a register on the M09 firmware.
Therefore , writing to gain seems to overflow into the offset register.This seems to be even in the lastet upstream driver so i created a patch for this driver which you find attached.
@Simon Budig
Find attached a patch to fix this edt driver bug, feel free to comment , test and commit upstream ;-)
He is right, his fix is correct. Please include his patch into the repository.
Thanks,
Simon
Signature · 3 lines
Simon Budig kernel concepts GmbH
[email protected] Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 SiegenFrom 36b9ac0e8206efefc8795c925b0f3b63ab29fd08 Mon Sep 17 00:00:00 2001
From: Robert Woerle <[email protected]>
Date: Wed, 28 May 2014 13:22:09 +0200
Subject: [PATCH] Input: edt-ft5x06 - fix i2c writes to 2 bytes on M09
firmware
--- drivers/input/touchscreen/edt-ft5x06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/edt-ft5x06.c +1 -1
@@ -271,7 +271,7 @@ static int edt_ft5x06_register_write(struct edt_ft5x06_ts_data *tsdata, wrbuf[0 ] = addr; wrbuf[1 ] = value; -return edt_ft5x06_ts_readwrite (tsdata->client,3 , +return edt_ft5x06_ts_readwrite (tsdata->client,2 , wrbuf,0 ,NULL );default :
Signature · 1 line
1.7.9.5
Quoted 16 lines · Simon Budig
Hi all.
I received notice from Robert Wörle who spotted a bug in the ft5x06 driver (M09 support) which can result in bogus values being written into the configuration registers.
Quoted 9 lines · Paul
I think i found the problem, as the driver sends 3 bytes instead of 2 when accessing a register on the M09 firmware.
Therefore , writing to gain seems to overflow into the offset register.This seems to be even in the lastet upstream driver so i created a patch for this driver which you find attached.
@Simon Budig
Quoted 7 lines
Quoted 2 lines
Find attached a patch to fix this edt driver bug, feel free to comment , test and commit upstream ;-)
He is right, his fix is correct. Please include his patch into the repository.
Acked-by Simon Budig <[email protected]>
Applied, thank you.
Quoted 36 lines
Thanks,
SimonSignature · 15 lines
Simon Budig kernel concepts GmbH [email protected] Sieghuetter Hauptweg 48 +49-271-771091-17 D-57072 Siegen From 36b9ac0e8206efefc8795c925b0f3b63ab29fd08 Mon Sep 17 00:00:00 2001 From: Robert Woerle <[email protected]> Date: Wed, 28 May 2014 13:22:09 +0200 Subject: [PATCH] Input: edt-ft5x06 - fix i2c writes to 2 bytes on M09 firmware Signed-off-by: Robert Woerle <[email protected]> --- drivers/input/touchscreen/edt-ft5x06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/input/touchscreen/edt-ft5x06.c +1
-1@@ -271,7 +271,7 @@ static int edt_ft5x06_register_write(struct edt_ft5x06_ts_data *tsdata, wrbuf[0 ] = addr; wrbuf[1 ] = value; -return edt_ft5x06_ts_readwrite (tsdata->client,3 , +return edt_ft5x06_ts_readwrite (tsdata->client,2 , wrbuf,0 ,NULL );default :Signature · 1 line
1.7.9.5
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html