Skip to contentSkip to conversation

embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard

PATCH New Iain Paton 2 participants 2 messages Jun 9, 2014 – Aug 13, 2014

lore
Share & tools
lore

Iain Paton

author
#0 lore raw

PATCH 1/1 embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard

On MarS usdhc3 is eMMC, on RIoT usdhc3 is uSD and eMMC is usdhc4.

Don't run the MarS specific eMMC reset code on usdhc3 when board_type == BOARD_IS_RIOTBOARD

Signed-off-by Iain Paton <[email protected]>
---
 board/embest/mx6boards/mx6boards.c | 1 +
 1 file changed, 1 insertion(+)
board/embest/mx6boards/mx6boards.c +1 -0
index d06b57d..530ea4f 100644
@@ -246,6 +246,7 @@ int board_mmc_init(bd_t *bis)
 					riotboard_usdhc3_pads,
 					ARRAY_SIZE(riotboard_usdhc3_pads));
 				gpio_direction_input(USDHC3_CD_GPIO);
+			} else {
 				gpio_direction_output(IMX_GPIO_NR(7, 8) , 0);
 				udelay(250);
 				gpio_set_value(IMX_GPIO_NR(7, 8), 1);
Signature · 1 line
1.8.5.1
#1 lore raw

PATCH 1/1 embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard

Hi Ian,

Quoted 10 lines · Iain Paton

On MarS usdhc3 is eMMC, on RIoT usdhc3 is uSD and eMMC is usdhc4.

Don't run the MarS specific eMMC reset code on usdhc3 when board_type == BOARD_IS_RIOTBOARD

Signed-off-by Iain Paton <[email protected]>
---
 board/embest/mx6boards/mx6boards.c | 1 +
 1 file changed, 1 insertion(+)

Digging deeper in patchwork, I found I have not yet applied this old patch. Sorry for that.

board/embest/mx6boards/mx6boards.c int board_mmc_init(bd_t *bis) · line 252

Quoted 13 lines
board/embest/mx6boards/mx6boards.c +1 -0
index d06b57d..530ea4f 100644
@@ -246,6 +246,7 @@ int board_mmc_init(bd_t *bis)
 					riotboard_usdhc3_pads,
 					ARRAY_SIZE(riotboard_usdhc3_pads));
 				gpio_direction_input(USDHC3_CD_GPIO);
+			} else {
 				gpio_direction_output(IMX_GPIO_NR(7, 8) , 0);
 				udelay(250);
 				gpio_set_value(IMX_GPIO_NR(7, 8), 1);

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================