drivers/firmware: return actual error on sysfs init
PATCH 8/24 drivers/firmware: return actual error on sysfs init
From: Jie Liu <[email protected]>
This patch fix all sysfs init functions under firmware subsystems to return the actual error if call kset_create_and_add() failed.
Cc Stefan Richter <[email protected]>
Signed-off-by Jie Liu <[email protected]>
--- drivers/firmware/dmi-sysfs.c | 4 +++- drivers/firmware/edd.c | 4 ++-- drivers/firmware/efi/efivars.c | 4 ++-- drivers/firmware/efi/runtime-map.c | 4 ++-- drivers/firmware/memmap.c | 4 ++-- 5 files changed, 11 insertions(+), 9 deletions(-)
drivers/firmware/dmi-sysfs.c +3 -1
@@ -657,8 +657,10 @@ static int __init dmi_sysfs_init(void) goto err; dmi_kset =kset_create_and_add ("entries" ,NULL , dmi_kobj); -if (!dmi_kset) +if (IS_ERR (dmi_kset)) { + error =PTR_ERR (dmi_kset); goto err; + } val =0 ; error =dmi_walk (dmi_sysfs_register_handle, &val);
drivers/firmware/edd.c +2 -2
@@ -757,8 +757,8 @@ edd_init(void) } edd_kset =kset_create_and_add ("edd" ,NULL , firmware_kobj); -if (!edd_kset) -return -ENOMEM ; +if (IS_ERR (edd_kset)) +return PTR_ERR (edd_kset);for (i =0 ; i <edd_num_devices (); i++) { edev =kzalloc (sizeof (*edev),GFP_KERNEL );
drivers/firmware/efi/efivars.c +2 -2
@@ -730,9 +730,9 @@ int efivars_sysfs_init(void) EFIVARS_DATE); efivars_kset =kset_create_and_add ("vars" ,NULL , parent_kobj); -if (!efivars_kset) { +if (IS_ERR (efivars_kset)) {printk (KERN_ERR "efivars: Subsystem registration failed.\n" ); -return -ENOMEM ; +return PTR_ERR (efivars_kset); } efivar_init(efivars_sysfs_callback, NULL, false,
drivers/firmware/efi/runtime-map.c +2 -2
@@ -113,8 +113,8 @@ add_sysfs_runtime_map_entry(struct kobject *kobj, int nr)if (!map_kset) { map_kset =kset_create_and_add ("runtime-map" ,NULL , kobj); -if (!map_kset) -return ERR_PTR (-ENOMEM ); +if (IS_ERR (map_kset)) +return ERR_CAST (map_kset); } entry =kzalloc (sizeof (*entry),GFP_KERNEL );
drivers/firmware/memmap.c +2 -2
@@ -186,8 +186,8 @@ static int add_sysfs_fw_map_entry(struct firmware_map_entry *entry)if (!mmap_kset) { mmap_kset =kset_create_and_add ("memmap" ,NULL , firmware_kobj); -if (!mmap_kset) -return -ENOMEM ; +if (IS_ERR (mmap_kset)) +return PTR_ERR (mmap_kset); } entry->kobj.kset = mmap_kset;
Signature · 1 line
1.8.3.2
Quoted 7 lines · Jeff Liu
From: Jie Liu <[email protected]>
This patch fix all sysfs init functions under firmware subsystems to return the actual error if call
kset_create_and_add()failed.Cc Stefan Richter <[email protected]>Signed-off-by Jie Liu <[email protected]>
Quoted 7 lines
--- drivers/firmware/dmi-sysfs.c | 4 +++- drivers/firmware/edd.c | 4 ++-- drivers/firmware/efi/efivars.c | 4 ++-- drivers/firmware/efi/runtime-map.c | 4 ++-- drivers/firmware/memmap.c | 4 ++-- 5 files changed, 11 insertions(+), 9 deletions(-)
Stefan, please do not take this patch.
thanks,
greg k-h