Skip to contentSkip to conversation

Are Small Changes in kernel accepted as patches

DISCUSSION karthik 4 participants 5 messages Jun 21, 2014

lore
Share & tools
lore

karthik

author
#0 lore raw

Hey There,
I was just going through the linux-next source and found a small change in one of the files. (Unnecessary else)
Now should I make this a patch and submit it or is it too small to submit? Regards
Karthik Nayak

#1 lore raw
Quoted 7 lines · karthik

Hey There,
I was just going through the linux-next source and found a small change in one of the files. (Unnecessary else)
Now should I make this a patch and submit it or is it too small to submit? Regards
Karthik Nayak

Any patch can never be "to small", in fact small changes/patches are preferred over large changes/patches.

#2 lore raw
Quoted 10 lines · Jeff Kirsher
Quoted 6 lines · karthik

Hey There,
I was just going through the linux-next source and found a small change in one of the files. (Unnecessary else)
Now should I make this a patch and submit it or is it too small to submit? Regards
Karthik Nayak

Any patch can never be "to small", in fact small changes/patches are preferred over large changes/patches.

there is a special email address for innocuous patches --
"trivial at kernel.org".

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#3 lore raw
In reply to karthik
Quoted 2 lines · karthik

I was just going through the linux-next source and found a small change in one of the files. (Unnecessary else)

One-line patches that fix misleading logic are always welcome.

Just remember to:

1_ Read Documentation/SubmititingPatches.txt and follow the directions

2) In the patch description/ changelog explain *why* the 'else' is unneeded
as that's a change in the program logic. And then fix it correctly - if
the else is unneeded because you can prove it's deal code because the
if condition is always true, then the 'if then' part can probably be
fixed up as well....
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140621/db1304c4/attachment.bin

author
#4 lore raw
Quoted 8 lines · Valdis.Kletnieks at vt.edu
Quoted 2 lines · karthik

I was just going through the linux-next source and found a small change in one of the files. (Unnecessary else)

One-line patches that fix misleading logic are always welcome.

Just remember to:

Quoted 7 lines

1_ Read Documentation/SubmititingPatches.txt and follow the directions

2) In the patch description/ changelog explain *why* the 'else' is unneeded
as that's a change in the program logic. And then fix it correctly - if
the else is unneeded because you can prove it's deal code because the if condition is always true, then the 'if then' part can probably be fixed up as well....

Brilliant
Thanks for the replies