Skip to contentSkip to conversation

Circular dependency introduced in commit 86f6cf4127

BUG Jeff Mahoney 3 participants 3 messages Jun 25, 2014 – Jun 26, 2014

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jeff Mahoney

author
#0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi guys -

Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a circular dependency between libphy and of_mdio.

depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in dependency cycle!
depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.19 (Darwin)

iQIcBAEBAgAGBQJTqu5iAAoJEB57S2MheeWyPMwP/3tpviCx3A70xZMxdS1QA4uK oyoTgTK+y0i6gTh4Mtkehzt6+lZAHyRso1OkUfo0oHflFDHQFbfHmN4ec1NIghpz L3XdLaYx0U485ziFtmnbaWm24lhgOwyK33QTMZANJ0OiOSOqNY5+NG8uxH1XOrJj eklbNo5Cya6Veqy1P4LovfrlNK1RflGcxdPOq2a7GVpJP7dP4wupoPIhIKCZD7O0 EL3Fo9bJ3+PNZT9pAaavBx6fjqqjLGOdj3QeBSkXxYvE5rueH0UNESZM+hytgQmo dIItCY0b95aJsxf26OcjJoWJgVX81GTlrT+HBzTLD5uKqHvi0Zt/A6RduWeS3am3 2WxlXGaFshiqeRpm+0gz5OzZnWKaLLpxMmMKqrdFFSKoaPHdqcBcKbqp2yKqGXdk sUN/qCA5S3JPpxwbKoZOAR03NIvq6b5wyK2/LKsU3HY9eMjmGh5m1vcFnWSZ21BM lz70tqdoWchZ9FqffE2tKsDdtaL/HOFrcq5kcRnoy5L/F5HJ4TPh/t33bTN4D8Zw lpTPe4LgtcN1dLlgDFVLDwAHDYWQ+BBOPUYjCVtXhFCzknl+uhB4OYZ8lsb/Wx8u apBeq3M/+wGMQw5khVOW6wM7r6EklqJbs0Zbova8aUaxknbTK4weJXAnW6BCWzHZ 6AX74FFiHH+pt/xFK8fQ
=C7lH
-----END PGP SIGNATURE-----

maintainer
#1 lore raw

From: Jeff Mahoney <[email protected]>
Date: Wed, 25 Jun 2014 11:44:34 -0400

Quoted 6 lines

Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a circular dependency between libphy and of_mdio.

depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in dependency cycle!
depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!

Yeah, of_mdio.c references &mdio_bus_type and libphy now references of_mdiobus_link_phydev.

Daniel, please work on fixing this, thanks.

#2 lore raw
Quoted 6 lines · David Miller

From: Jeff Mahoney <[email protected]>
Date: Wed, 25 Jun 2014 11:44:34 -0400

Quoted 3 lines

Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a circular dependency between libphy and of_mdio.

Quoted 9 lines
Quoted 3 lines

depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in dependency cycle!
depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!

Yeah, of_mdio.c references &mdio_bus_type and libphy now references of_mdiobus_link_phydev.

Daniel, please work on fixing this, thanks.

Patch sent. Apologies for the breakage!

Daniel