Skip to contentSkip to conversation

on 2nd try mount.cifs must also uppercase "orig_dev" - recent kernels now ignore "unc=..." mount option

PATCH In review Günter Kukkukk 2 participants 3 messages Jul 1, 2014 – Jul 3, 2014 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 on 2nd try mount.cifs must also uppercase "orig_dev" - recent kernels now ignore "unc=..." mount option

userland mount helper mount.cifs.

Also uppercase the now used (kernel) "orig_dev" parameter, to get the mount retry working again.

Cheers, Günter

Quoted 1 line

From 5b6633b93b4df19b6c2863b8c9cf11d622132b60 Mon Sep 17 00:00:00 2001

From: Guenter Kukkukk <[email protected]>
Date: Tue, 1 Jul 2014 17:43:55 +0200
Subject: [PATCH] on 2nd try mount.cifs must also uppercase "orig_dev" - recent
kernels now ignore "unc=..." mount option

mount.cifs.c, when getting errno=ENXIO, retries the mount with uppercased hostname, sharename and prefixpath in the "unc=..." mount option, which is ignored now in the kernel. Used e.g. during OS/2 mounts, which fail now.

Also uppercase the now used "orig_dev" parameter.

---
 mount.cifs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mount.cifs.c +2 -1
index 497665d..3535096 100644
@@ -2097,7 +2097,8 @@ mount_retry:
 			if (!already_uppercased &&
 			    uppercase_string(parsed_info->host) &&
 			    uppercase_string(parsed_info->share) &&
-			    uppercase_string(parsed_info->prefix)) {
+			    uppercase_string(parsed_info->prefix) &&
+			    uppercase_string(orig_dev)) {
 				fprintf(stderr,
 					"Retrying with upper case share name\n");
 				already_uppercased = 1;
Signature · 1 line
1.8.4.5

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 6 lines · On Tue, 01 Jul 2014 19:05:29 +0200 Günter Kukkukk…

userland mount helper mount.cifs.

Also uppercase the now used (kernel) "orig_dev" parameter, to get the mount retry working again.

Cheers, Günter

Thanks Günter. Patch looks correct to me. I'll merge it within the next few days unless someone objects.

Cheers!

Signature · 1 line
Jeff Layton <[email protected]>