Skip to contentSkip to conversation

ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator

PATCH Superseded Khiem Nguyen 2 participants 2 messages Jul 3, 2014 – Jul 5, 2014

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator

I2C bus for VDD MPU regulator is IIC3, not I2C3.

---
  arch/arm/boot/dts/r8a7790-lager.dts |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
(quoted diff) +0 -0

b/arch/arm/boot/dts/r8a7790-lager.dts
index 0890d47..a8f32d7 100644

arch/arm/boot/dts/r8a7790-lager.dts +5 -5
@@ -215,9 +215,9 @@
          renesas,function = "i2c2";
      };
 
-    i2c3_pins: i2c3 {
-        renesas,groups = "i2c3";
-        renesas,function = "i2c3";
+    iic3_pins: iic3 {
+        renesas,groups = "iic3";
+        renesas,function = "iic3";
      };
  };
 
@@ -353,9 +353,9 @@
      pinctrl-names = "default";
  };
 
-&i2c3 {
+&iic3 {
      pinctrl-names = "default";
-    pinctrl-0 = <&i2c3_pins>;
+    pinctrl-0 = <&iic3_pins>;
      status = "okay";
 
      vdd_dvfs: regulator@68 {
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 6 lines · Khiem Nguyen

I2C bus for VDD MPU regulator is IIC3, not I2C3.

---
 arch/arm/boot/dts/r8a7790-lager.dts |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Hi Khiem-san,

Thanks for your patch. Can you please extend the commit message to include the reason behind this patch?

From my side this looks like a software policy change. Unless I'm mistaken both I2C3 and IIC3 share the same pins on the SoC, and because of that it should be possible to access that particular I2C bus already without any modification.

So please explain why you want to change this.

Cheers,

/ magnus