Skip to contentSkip to conversation

drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM

PATCH Applied Chen Gang 2 participants 2 messages Jul 8, 2014 – Jul 21, 2014 Clocksource, clockevent drivers

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM

In 'em_sti.c', it will call devm_ioremap_resource() which need HAS_IOMEM. So need let EM_TIMER_STI depend on HAS_IOMEM, too.

The related error (with allmodconfig under score):

LD init/built-in.o
em_sti.c:(.text.em_sti_probe+0x84): undefined reference to `devm_ioremap_resource'
make: *** [vmlinux] Error 1

Signed-off-by Chen Gang <[email protected]>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/Kconfig +1 -1
index 8ad1eac..ce372d6 100644
@@ -190,7 +190,7 @@ config SH_TIMER_TMU
 
 config EM_TIMER_STI
 	bool "Renesas STI timer driver" if COMPILE_TEST
-	depends on GENERIC_CLOCKEVENTS
+	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
 	default SYS_SUPPORTS_EM_STI
 	help
 	  This enables build of a clocksource and clockevent driver for
Signature · 1 line
1.9.2.459.g68773ac
Applied
#1 lore raw
Quoted 20 lines · Chen Gang

In 'em_sti.c', it will call devm_ioremap_resource() which need HAS_IOMEM. So need let EM_TIMER_STI depend on HAS_IOMEM, too.

The related error (with allmodconfig under score):

LD init/built-in.o
em_sti.c:(.text.em_sti_probe+0x84): undefined reference to `devm_ioremap_resource'
make: *** [vmlinux] Error 1

Signed-off-by Chen Gang <[email protected]>
---
  drivers/clocksource/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/Kconfig +0 -0
index 8ad1eac..ce372d6 100644

drivers/clocksource/Kconfig config SH_TIMER_TMU · line 196

Quoted 8 lines
drivers/clocksource/Kconfig +1 -1
@@ -190,7 +190,7 @@ config SH_TIMER_TMU
 
  config EM_TIMER_STI
  	bool "Renesas STI timer driver" if COMPILE_TEST
-	depends on GENERIC_CLOCKEVENTS
+	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
  	default SYS_SUPPORTS_EM_STI
  	help
  	  This enables build of a clocksource and clockevent driver for

Applied to my tree for 3.17

Thanks

-- Daniel

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog